Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix same bootstrap register requests from diff target clusters #47

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix same bootstrap register requests from diff target clusters #47

merged 3 commits into from
Mar 31, 2023

Conversation

niravparikh05
Copy link
Contributor

@niravparikh05 niravparikh05 commented Mar 22, 2023 •
edited

What does this PR change?

  • fix to error out same bootstrap agent registration requests from different target clusters

Does the PR depend on any other PRs or Issues? If yes, please list them.

Checklist

I confirm, that I have...

  • Read and followed the contributing guide in CONTRIBUTING.md
  • Added tests for this PR
  • Formatted the code using go fmt (if applicable)
  • Updated documentation on the Paralus docs site (if applicable)
  • Updated CHANGELOG.md

@niravparikh05 niravparikh05 linked an issue Mar 22, 2023 that may be closed by this pull request
I inadvertently installed a relay agent in multiple clusters paralus/paralus#131
Closed
@niravparikh05
Copy link
Contributor Author

niravparikh05 commented Mar 23, 2023 •
edited

Pending

  • Update go.mod once dependent pr is merged

@niravparikh05 niravparikh05 mentioned this pull request Mar 23, 2023
Closed
5 tasks
akshay196
akshay196 requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@akshay196 akshay196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getNamespace can be unit tested using fake kube-client, for example fake dynamic client.

pkg/agent/agent.go Outdated Show resolved Hide resolved
pkg/agent/agent.go Outdated Show resolved Hide resolved
@niravparikh05 @akshay196
fix: same bootstrap register requests from diff target clusters
788f41d 
Signed-off-by: niravparikh05 <nir.parikh05@gmail.com>
Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
@akshay196
Copy link
Member

@niravparikh05 Added unit test and squashed all commits to one.

@niravparikh05
Copy link
Contributor Author

@niravparikh05 Added unit test and squashed all commits to one.

thank you @akshay196

nirav-rafay
nirav-rafay approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@nirav-rafay nirav-rafay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akshay196 akshay196 merged commit cdf6f39 into main Mar 31, 2023
@akshay196 akshay196 mentioned this pull request Apr 1, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshay196 akshay196 akshay196 approved these changes

@nirav-rafay nirav-rafay nirav-rafay approved these changes

Assignees

@niravparikh05 niravparikh05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I inadvertently installed a relay agent in multiple clusters
3 participants
@niravparikh05 @akshay196 @nirav-rafay