New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix RSA key loading: p and q were being swapped #1723
Conversation
This currently works, because OpenSSL simply re-computes iqmp when it doesn't match the p & q values. However a future pyca/cryptography patch enforces this.
fwiw, even though this currently runs without error, it's causing OpenSSL to constantly recompute iqmp, which makes it much slower. Twisted used to have a similar issue: twisted/twisted@737db21 |
Cherry picked back to Paramiko 2.7. Thanks! |
Thanks Jeff! |
(Later edit: the answer to this question is now.) |
This currently works, because OpenSSL simply re-computes iqmp when it doesn't match the p & q values. However a future pyca/cryptography patch enforces this.