Add support of quoted values for SSHConfig#184
Add support of quoted values for SSHConfig#184bitprophet merged 3 commits intoparamiko:masterfrom ykalchevskiy:master
Conversation
|
Can you rebase this on current master and i'll review it? |
|
Done. |
|
Splitting it would be awesome! Would also be great if you created a separate test for the get_hosts method (I am looking into creating more unittest like tests too and then, we'd at least have a test for that method in place). |
|
Ok, I splitted the commit and also moved the get_hosts function into a separate method (with tests). |
|
Cool! |
|
Hi @lndbrg, |
|
@ykalchevskiy yes I want this merged, please rebase (again, sorry about that) It's @bitprophet that does the merging, so we need to pike him. Right now i know that he has quite a long shortlist though. |
|
Thanks @lndbrg, I've rebased it. Ok, at least we noted him here, may be he will add this to the end of his list :) |
|
Months later: I get notified on everything for the repo, no need to namedrop me :D github doesn't make the notification any bigger sadly. Skimmed the PR and it looks reasonable, so I +1 to the Reviewed label, I'll probably merge this for 1.15 when I finish triage catchup. Thanks! |
|
Thanks! |
Hi!
Added support of quoted values for SSHConfig (with tests).
Simplified handling of the configuration file: used one universal regexp instead of symbol manipulation and regexp for proxycommand only.