-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:Before killing a process under high concurrency, it is necessary … #2261
Open
nuonuonn
wants to merge
5
commits into
paramiko:main
Choose a base branch
from
nuonuonn:branch_fix_kill
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2cd447b
fix:Before killing a process under high concurrency, it is necessary …
nuonuonn de37882
fix:Check if the process still exists before killing it
nuonuonn 39b4279
add:comments
nuonuonn 82375a6
fix:terminate the subprocess if alive.
nuonuonn 13b937b
fix:terminate the subprocess if alive.Close pipes.
nuonuonn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other errors that could be raised during these stream closure actions? If anything other than a
ProcessLookupError
occurs, then theexcept
won't catch correctly.If I read the docs right,
close()
is idempotent and won't raise on an already-closed stream... so, there may not actually be any additional errors to worry about?If so, augmenting your comment here to note that
close()
won't raise even if the streams are already closed would be good.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
close()
is redundant, I have deleted it.But it is necessary to check whether a process is still present before killing it.
Because when I use distributed task queues Celery, this process is usually killed by the system.
It is possible to report an error
ProcessLookupError
.In short, it is necessary to check whether a process is still alive before killing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I think I expressed myself poorly -- I wasn't requesting that you change your implementation, only that you add some comments &c. to document it more thoroughly.
Although, if that
if self.closed:
check will do just as well as the full set of stream.close()
calls and thetry
/except
, that's certainly much cleaner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to close IO as it will kill directly