Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PyCryptodome (and PyPy) #727

Closed
wants to merge 5 commits into from
Closed

Add support for PyCryptodome (and PyPy) #727

wants to merge 5 commits into from

Conversation

Legrandin
Copy link

Shamelessly resubmitting this pull request (was #646).
Maybe it is acceptable at least for a 1.x branch (not 2.x)?

This patch makes paramiko work with PyCryptodome instead of PyCrypto.
With the former, paramiko can run under PyPy (and way more easily on Windows!).

@bitprophet
Copy link
Member

bitprophet commented Apr 25, 2016

The Cryptography.io merge is Actually Happening For Real™ and a 2.0 using it will be out within the next day or two. See #394's more recent activity :)

I'd be willing to hear discussion in the case where Cryptography.io was somehow harder to install than PyCryptodome for some users, but I'd guess that's not the case given the attention PyCA has put into their packaging! (And it would still require a lot of additional maintenance work, plus not feasible for the 1.x line - changing install requirements to this level is pretty backwards incompat for most users.)

Regardless, thanks for putting in the effort on this & apologies for the earlier foot-dragging on #394.

@bitprophet bitprophet closed this Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants