Resolved infinite loop between two layering PDPs, added new class to make resolving this easier

[tjcouch-sil]

[Breaking] Had to add a new requirement for layering PDPFs. Just extend from the class LayeringProjectDataProviderEngineFactory available on @papi/backend in order to fulfill this requirement automatically.

• Long explanation of the requirement: getAvailableProjects now receives a parameter which is some subset of the filtering options being used while calling getAvailableProjects on this PDPF. The subset of filtering options will primarily contain some set of PDPF ids to exclude from the search in order to avoid infinitely recurring calls to other layering PDPFs' getAvailableProjects. Base PDPFs can ignore that parameter, but layering PDPFs that call papi.projectLookup.getMetadataForAllProjects to get some set of existing project ids to layer over absolutely must now merge the filter options passed into getAvailableProjects into the filter options they use when calling papi.projectLookup.getMetadataForAllProjects.

---

This change is 

[lyonsil]

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tjcouch-sil)

---

src/shared/models/project-data-provider-engine-factory.model.ts line 27 at r1 (raw file):

 * {@link IBaseProjectDataProvider} and {@link ProjectDataProviderInterfaces} for more information.
 *
 * WARNING: For Layering PDPFs, `getAvailableProjects` has very specific requirements that

It seems a little odd to put a big warning here without explaining the warning in some way. This and the following paragraph make it seem like there is a special handshake that gets kicked out of the club if you don't know it.

[tjcouch-sil]

Reviewable status: 10 of 12 files reviewed, 1 unresolved discussion (waiting on @lyonsil)

---

src/shared/models/project-data-provider-engine-factory.model.ts line 27 at r1 (raw file):

Previously, lyonsil (Matt Lyons) wrote…

It seems a little odd to put a big warning here without explaining the warning in some way. This and the following paragraph make it seem like there is a special handshake that gets kicked out of the club if you don't know it.

Does the link make it better?

[lyonsil]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

src/shared/models/project-data-provider-engine-factory.model.ts line 27 at r1 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

Does the link make it better?

LOL - At first nope, but now that I see it in Reviewable I'm all good. 😄

[tjcouch-sil]

Reviewable status: complete! all files reviewed, all discussions resolved

---

src/shared/models/project-data-provider-engine-factory.model.ts line 27 at r1 (raw file):

Previously, lyonsil (Matt Lyons) wrote…

LOL - At first nope, but now that I see it in Reviewable I'm all good. 😄

Oh sorry I meant the {@link... I added in the TSDoc. Thanks!