Add loop and initial design of prune combinator #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 11, 2017 16:47
add a Task pool for each use of the loop combinator. the task pool uses a round-robin lock-free algorithm to dispatch work to each worker. it loads balances a task to each actor. this may not be the best strategy if an actor gets more complex tasks. if necessary, we can fix this in the next iteration. load balancing with relaxed memory semantics.
prune can be seen as a ParT that streams a single value.
prune :: (Fut[Maybe[t]] -> Par[t']) -> Par[t] -> Par[t']
given its signature, we can understand that the ParT given as second
argument streams the first value out of it to the future in the first
argument. after that, we proceed by trying to kill the remaining
computations. the killing part is not finished yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the loop combinator and the initial design of the prune combinator (i.e. no killing yet).
loop :: Par[t] -> (t -> Par[t']) -> (t' -> bool) -> Par[t']this combinator for performing useful computations until all elements in the ParT satisfy an exit condition. Elements that satisfy the exit condition do not need to continue iterating and can be asynchronously "streamed" to other ParT combinators. This combinator has been added based on experience from the SAT solver case study.prune :: (Fut[Maybe[t]] -> Par[t']) -> Par[t]) -> Par[t']this combinator puts in the future the first computation that finishes from thePar[t](second argument). The function call is executed immediately, returning a new ParT (Par[t']). At the C level, the implementation uses a lock-free algorithm to ensure that only one item in the ParT fulfils the future. The killing part of remaining computations needs a bit more work and will be submitted in another PR. This should keep things simple and the review of the killing deserves its own PR (work-in-progress)I have added tests to the loop and prune combinators.