New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ack standup update received #1

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@nberger
Contributor

nberger commented Mar 23, 2014

No description provided.

)
(defn- answer-message

This comment has been minimized.

@paraseba

paraseba Mar 26, 2014

Owner

the correct way to do this will depend on the GroupChat impl, so this should be either a new method in the protocol or a new arity for write method

This comment has been minimized.

@nberger

nberger Mar 26, 2014

Contributor

I like it more to be a new method in the protocol than adding a new arity, because of being more explicit. Let's do that.

(do
(sstate/add-status state (:room message) (:from message) updates)
(ack-status-received group-chat session message updates))
(answer-message group-chat session message "That didn't look like a standup update..."))))

This comment has been minimized.

@paraseba

paraseba Mar 26, 2014

Owner

I think we should remain silent when we can't parse the message, people will mention eliga for other things. People will get used to the positive response when everything is OK, I don't think they need an error message

Don't ack a message without an update
Users will get used to only receive positive ack messages. There's no
need to ack for messages without updates
@paraseba

This comment has been minimized.

Owner

paraseba commented Mar 29, 2014

please reimplement using the new private messages

@nberger

This comment has been minimized.

Contributor

nberger commented Mar 30, 2014

continued on #4

@nberger nberger closed this Mar 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment