Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle dubious texture sizes #240

Closed
parasyte opened this issue Dec 7, 2021 · 0 comments · Fixed by #250
Closed

Properly handle dubious texture sizes #240

parasyte opened this issue Dec 7, 2021 · 0 comments · Fixed by #250
Labels
bug Something isn't working

Comments

@parasyte
Copy link
Owner

parasyte commented Dec 7, 2021 •
edited

There is a wgpu issue that we need to work around: gfx-rs/wgpu#1010 I started experimenting with a patch that makes texture creation fallible by checking device limits and changing some APIs to return Result.

I ran into a number of problems with automated testing. The big one is that pixels-mocks is still not runnable (but it's ok for compilation tests). See #80. Using winit in integration tests has some issues with creating the event-loop off the main thread, at least on Windows. It can be done with platform-specific extensions. And then tests may not be able to run on all platforms.
@parasyte parasyte added the bug Something isn't working label Dec 7, 2021
@parasyte parasyte changed the title Properly handle dubious sizes Properly handle dubious texture sizes Dec 15, 2021
parasyte added a commit that referenced this issue Jan 8, 2022
@parasyte
Fix invalid texture sizes
73a3fd4 
- Makes methods fallible when they create textures.
- Correctly handle window resize in fltk and sdl2 examples.
- TODO: tests
- Closes #240
@parasyte parasyte mentioned this issue Jan 8, 2022
Merged
parasyte added a commit that referenced this issue Dec 18, 2022
@parasyte
Fix invalid texture sizes
5803e14 
- Makes methods fallible when they create textures.
- Correctly handle window resize in fltk example.
- TODO: tests
- Closes #240
parasyte added a commit that referenced this issue Dec 18, 2022
@parasyte
Fix invalid texture sizes (#250)
6f4fa6c 
- Makes methods fallible when they create textures.
- Correctly handle window resize in fltk example.
- TODO: tests
- Closes #240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid texture sizes parasyte/pixels
1 participant
@parasyte