Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pixels::Error
is now marked#[non_exhaustive]
Pixels::resize_buffer()
andPixels::resize_surface()
returnResult<_, TextureError>
.Pixels::resize_buffer()
no longer panics on invalid inputs.I haven't written any tests for this, because I still don't have a great solution to the issue raised in #80.
This does add a lot of noise to the examples. I can perhaps address some of that with
Result
transformation methods. The "print error and exit event loop" pattern is very common in these examples but might need more intelligent handling in a real application.