Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add builder method for setting VSync #57

Closed
parasyte opened this issue Feb 21, 2020 · 1 comment · Fixed by #78
Closed

Add builder method for setting VSync #57

parasyte opened this issue Feb 21, 2020 · 1 comment · Fixed by #78
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@parasyte
Copy link
Owner

VSync is currently hardcoded on:

pixels/src/lib.rs

Line 455 in 7701ac2

present_mode: wgpu::PresentMode::Vsync,

It's important to make this optional so that users can decide if they prefer no screen tearing (VSync on) or low latency (VSync off).
@parasyte parasyte added enhancement New feature or request good first issue Good for newcomers labels Feb 21, 2020
@parasyte
Copy link
Owner Author

The default value was changed to wgpu::PresentMode::Mailbox (a good default). We'll still want this configurable, though.

pixels/src/lib.rs

Line 169 in 9de2383

present_mode: wgpu::PresentMode::Mailbox,

pixels/src/lib.rs

Line 476 in 9de2383

present_mode: wgpu::PresentMode::Mailbox,

@Aeledfyr Aeledfyr mentioned this issue May 15, 2020
Merged
@parasyte parasyte mentioned this issue Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add builder methods for VSync and setting wgpu backend Aeledfyr/pixels
1 participant
@parasyte