Add builder methods for VSync and setting wgpu backend #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* enable_vsync sets the VSync mode * wgpu_backend sets the wgpu BackendBit struct * Made RequestAdapterOptions use compatible_surface by default
parasyte
reviewed
May 17, 2020
This doesn't expose the PresentMode for the external api, because the variants of PresentMode aren't very obvious to people without wgpu experience. Mailbox corresponds to VSync enabled, and Immediate corresponds to VSync disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_vsyncsets the VSync modewgpu_backendsets the wgpuBackendBitstructRequestAdapterOptionsusecompatible_surfaceby default. This doesn't do much for most cases, but it may avoid problems for some specific setups and seems to be the correct thing to do.This fixes #57 and #75.