Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wgpu from 0.13 to 0.14 #320

Merged
merged 10 commits into from
Dec 17, 2022
Merged

Conversation

dtcristo
Copy link
Contributor

@dtcristo dtcristo commented Dec 14, 2022

Continuing on from #312 by @Zageron, I've addressed some feedback from that PR. I've also updates some crates in a few of the examples so they can now work with wgpu 0.14.

Details

  • Addressed feedback from chore(deps): upgrade wgpu from 13 to 14 #312.
  • Fixed imgui-winit example by bumping a few crates and fixing some API changes.
  • Fixed minimal-tao example by bumping tao from 0.12 to 0.15.
  • Fixed minimal-fltk example by bumping fltk from 1.3.13 to 1.3.17.
  • Fixed minimal-egui example by buumping egui, egui-wgpu and egui-winit from 0.19 to 0.20. Also made some code changes to support this new version.
  • Bumped MSRV from 1.61 to 1.65 as egui 0.20 has dependencies that require 1.65.
  • Deleted minimal-sdl2 example.
  • Fixed new clippy lints.

@Zageron
Copy link
Contributor

Zageron commented Dec 14, 2022

Thank you so much! I am busy / out of country.

@dtcristo dtcristo force-pushed the update/wpgu-0.14 branch 2 times, most recently from 0058704 to 1ae8bed Compare December 14, 2022 06:54
@parasyte
Copy link
Owner

Thank you!

The latest news I saw about imgui is that they have been slowly making progress to get their builds working again and they are already on the latest version of winit. Meanwhile there is an open PR for imgui-wgpu: Yatekii/imgui-wgpu-rs#87

For the SDL example, the sdl2 crate might be in a better position than it was a few years ago. But it's still on an old version of RWH: Rust-SDL2/rust-sdl2#1269

@parasyte
Copy link
Owner

  • Bumped MSRV from 1.61 to 1.65 as egui 0.20 has dependencies that require 1.65. This is just an example so we shouldn't really change the MSRV of pixels for that. However, CI scripts would need to change if we want to have an example that requires newer than our MSRV to build than is supported by pixels.

This is completely alright and expected, as described in the MSRV policy. We have a separate repo where the library-only MSRV is tested in isolation from the rest of the workspace: https://github.com/parasyte/pixels-ci-rust-version

In other news, imgui-wgpu is on the verge of a release right now. The previously mentioned PR has already been merged. That leaves the SDL example as the only holdout. I'm ok to delete that example for now until we have a good way to support it. It's more important that this update is merged than trying to push forward with an example that is of questionable quality, anyway.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@dtcristo dtcristo changed the title [WIP] Bump wgpu from 0.13 to 0.14 Bump wgpu from 0.13 to 0.14 Dec 17, 2022
@dtcristo dtcristo marked this pull request as ready for review December 17, 2022 12:12
@dtcristo
Copy link
Contributor Author

@parasyte, PR is now ready for review.

I ran CI from my fork and it's all passing. I had to fix a few new clippy lints that I guess are due to bump in MSRV.

I also deleted minimal-sdl2 example as you suggested.

Co-authored-by: Jay Oster <jay@kodewerx.org>
@parasyte parasyte merged commit e8d5cf3 into parasyte:main Dec 17, 2022
@parasyte
Copy link
Owner

Thank you @Zageron for the initial effort and @dtcristo for seeing this through to completion!

@Zageron
Copy link
Contributor

Zageron commented Dec 17, 2022

Thank you @Zageron for the initial effort and @dtcristo for seeing this through to completion!

I'm glad someone took the initiative! Thanks everyone. @dtcristo you rock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants