Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Phar executable on Release pages #322

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

Gasol
Copy link
Contributor

@Gasol Gasol commented May 31, 2018

To resolve #176, The Phar executable is very useful when root project has some dependency conflict with paratest, for example symfony/console.

This PR require Github token to work properly, You can replace APIKEY by editing files ("Allow edits from maintainers has checked"), It should work like following link.
https://github.com/Gasol/paratest/releases/tag/2.0.0

See also https://docs.travis-ci.com/user/deployment/releases/#Authenticating-with-an-OAuth-token and travis-ci/travis-ci#2457 (comment)

@michaelgv
Copy link
Contributor

Looks good! Can you resolve the conflicts?

@Gasol
Copy link
Contributor Author

Gasol commented Sep 21, 2018

Looks good! Can you resolve the conflicts?

done

@andreasschroth andreasschroth merged commit b3b5a3a into paratestphp:master Sep 24, 2018
@andreasschroth
Copy link
Member

Thank you, I merged your PR now.

@andreasschroth
Copy link
Member

So from what I can see, in order to get this working, we also need to add a deploy section in our .travis.yml file as in your file here? https://github.com/Gasol/paratest/blob/2.0.0/.travis.yml

Is that correct?

@Gasol
Copy link
Contributor Author

Gasol commented Sep 25, 2018

@andreasschroth You're correct, I forgot to include it in this PR. Please do it, thanks.

@andreasschroth
Copy link
Member

@Gasol Okay, thanks for the confirmation. I just added it in PR #338 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

phar package
3 participants