Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default console argument to auto #345

Merged
merged 4 commits into from Jan 25, 2019

Conversation

andrerom
Copy link
Contributor

I forgot this part in prior pull request, so doc and command is not aligned now in 2.1.

@andreasschroth
Copy link
Member

Oops! Thank you. But could you please fix the failing tests again? TravisCI is failing...

@andreasschroth
Copy link
Member

@andrerom Would be awesome, if you could update the failing tests. Otherwise I'll do that.

@andrerom
Copy link
Contributor Author

I won't be able to anytime soon.

@andrerom
Copy link
Contributor Author

andrerom commented Nov 21, 2018

@andreasschroth Fixed tests

EDIT: Failure on dev stability seems unrelated ❓

But I have no idea why the tests on travis gave following output before this fix Running phpunit in 32 processes with /home/travis/build/paratestphp/paratest/vendor/phpunit/phpunit/phpunit. Functional mode is ON.\n

As in it beats me why 32 processes where picked by auto code on Travis, I would expect far less as it's 1 or 2 cores there afaik.

So maybe we should check why this is the cases, as it seems what we read from /proc/cpuinfo reads info from host and not what we probably care for here, the guest.

@andreasschroth
Copy link
Member

andreasschroth commented Nov 21, 2018

@andrerom Thanks. Regarding failing test on PHP 7.2 dev: Well I guess phpunit changed something in their method signature, is definitely unrelated to this PR.

Regarding the 32 cores I was also a bit surprised at first - and thought they might be extremely generous. But yes, I looked it up under https://docs.travis-ci.com/user/reference/overview/ and it seems that Travis VMs run on 2 cores. I find it a bit weird though that /proc/cpuinfo inside the VM contains the information about the host, how exactly can that be?

@andrerom
Copy link
Contributor Author

andrerom commented Nov 21, 2018

how exactly can that be?

🤷‍♂️

Can't remember seeing this when testing on a ubuntu docker container locally long time ago, but as this is completely different hypervisor I'm unsure if it matters or not.

@matthewnessworthy
Copy link
Contributor

The unrelated failure relates to this commit ( sebastianbergmann/phpunit@f5e5add#diff-511c90242d5589e941582006e0485184R407 ) from 3 days ago

paslandau pushed a commit to paslandau/paratest that referenced this pull request Jan 24, 2019
…cu). Adds composer script info to README.
@andreasschroth andreasschroth merged commit b31aba9 into paratestphp:master Jan 25, 2019
@andreasschroth
Copy link
Member

Sorry for late merge, changes look good and failing CI is unrelated to this PR.

@andrerom andrerom deleted the patch-1 branch January 25, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants