-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default console argument to auto #345
Conversation
Oops! Thank you. But could you please fix the failing tests again? TravisCI is failing... |
@andrerom Would be awesome, if you could update the failing tests. Otherwise I'll do that. |
I won't be able to anytime soon. |
@andreasschroth Fixed tests EDIT: Failure on dev stability seems unrelated ❓ But I have no idea why the tests on travis gave following output before this fix As in it beats me why 32 processes where picked by auto code on Travis, I would expect far less as it's 1 or 2 cores there afaik. So maybe we should check why this is the cases, as it seems what we read from |
@andrerom Thanks. Regarding failing test on PHP 7.2 dev: Well I guess phpunit changed something in their method signature, is definitely unrelated to this PR. Regarding the 32 cores I was also a bit surprised at first - and thought they might be extremely generous. But yes, I looked it up under https://docs.travis-ci.com/user/reference/overview/ and it seems that Travis VMs run on 2 cores. I find it a bit weird though that |
🤷♂️ Can't remember seeing this when testing on a ubuntu docker container locally long time ago, but as this is completely different hypervisor I'm unsure if it matters or not. |
Update tests
The unrelated failure relates to this commit ( sebastianbergmann/phpunit@f5e5add#diff-511c90242d5589e941582006e0485184R407 ) from 3 days ago |
…cu). Adds composer script info to README.
Sorry for late merge, changes look good and failing CI is unrelated to this PR. |
I forgot this part in prior pull request, so doc and command is not aligned now in 2.1.