Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style issues, failing sqlite tests, testuites with "," (#347) #359

Merged
merged 3 commits into from Jan 25, 2019

Conversation

paslandau
Copy link

@paslandau paslandau commented Jan 24, 2019

Fixes style issues. Adds markTestSkipped to SqlRunner tests if pdo_sqlite is missing.

Enables splitting --testsuite option by ,. GH issue: #347

  • includes composer scripts to easily run test / style checks:
root@db51901fe7a6:/codebase/paratest# composer run-script -l
scripts:
  style            Runs the style script as defined in composer.json.
  style-fix        Runs the style-fix script as defined in composer.json.
  test             Run all tests
  test-unit        Run only unit tests
  test-functional  Run only functional tests

Pascal Landau added 2 commits January 24, 2019 12:09
…lite is missing.

Enables splitting --testsuite option by ,. GH issue: paratestphp#347
…cu). Adds composer script info to README.
Copy link
Member

@andreasschroth andreasschroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work, looks good. 👍 I only think it would have been better if the style issue fixes had been an own PR.

@andreasschroth andreasschroth merged commit 8cedbd8 into paratestphp:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants