Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: Configurable profiling frequency #1213

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

marselester
Copy link
Contributor

Frederic proposed --cpu-sampling-frequency flag #1212.

@marselester marselester requested a review from a team as a code owner January 10, 2023 17:21
@marselester marselester changed the title --cpu-sampling-frequency flag Configurable profiling frequency Jan 10, 2023
@marselester marselester changed the title Configurable profiling frequency profiler: Configurable profiling frequency Jan 10, 2023
Copy link
Contributor

@javierhonduco javierhonduco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

cmd/parca-agent/main.go Show resolved Hide resolved
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

I have a few comments. Happy to merge it afterward. I'll give @brancz to have a look at it, though.

README.md Outdated Show resolved Hide resolved
pkg/profiler/cpu/cpu.go Show resolved Hide resolved
pkg/profiler/pprof.go Outdated Show resolved Hide resolved
docs/design.md Outdated Show resolved Hide resolved
cmd/parca-agent/main.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cmd/parca-agent/main.go Outdated Show resolved Hide resolved
@kakkoyun kakkoyun merged commit b8a9f24 into parca-dev:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants