-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiler: Configurable profiling frequency #1213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marselester
changed the title
Configurable profiling frequency
Jan 10, 2023
--cpu-sampling-frequency
flag
marselester
changed the title
Configurable profiling frequency
profiler: Configurable profiling frequency
Jan 10, 2023
marselester
force-pushed
the
samplfreq
branch
from
January 10, 2023 17:34
ee650c4
to
e7aab63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
kakkoyun
reviewed
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
I have a few comments. Happy to merge it afterward. I'll give @brancz to have a look at it, though.
brancz
reviewed
Jan 11, 2023
brancz
reviewed
Jan 11, 2023
Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
marselester
force-pushed
the
samplfreq
branch
from
January 11, 2023 15:35
e60ddf1
to
86ef384
Compare
2 tasks
marselester
force-pushed
the
samplfreq
branch
from
January 11, 2023 18:46
e3f8249
to
97d0904
Compare
kakkoyun
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frederic proposed
--cpu-sampling-frequency
flag #1212.