Reduce size of object pool #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only land after #2031 as it fixes a race condition that we believe it was affecting the stability of the object pool |
|
@javierhonduco FYI, There is a formatting issue that causes CI to fail. |
512 elf.Files (+ other metadata) can really balloon memory usage. Assuming each entry is ~10 MB would result in a heap usage of at least 5 GB. Some of our users reported 10 GB in heap usage in the pool which is completely unreasonable. In the future we want to update this to have an adaptive mechanism so we can use the cache as much as possible while keeping memory usage at bay. Right now having a pool to small will result in more files being opened, (elf.Open) which results in lots of allocations and high CPU usage. Hence we have a tradeoff of CPU + allocations vs heap usage. Test Plan ========= Ran overnight without issues. Signed-off-by: Francisco Javier Honduvilla Coto <javierhonduco@gmail.com>
javierhonduco
force-pushed
the
reduce-size-of-object-pool
branch
from
bd590ba
to
e7aa5f1
Compare
|
Helpful bot 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
512 elf.Files (+ other metadata) can really balloon memory usage. Assuming
each entry is ~10 MB would result in a heap usage of at least 5 GB. Some
of our users reported 10 GB in heap usage in the pool which is
completely unreasonable.
In the future we want to update this to have an adaptive mechanism so we
can use the cache as much as possible while keeping memory usage at bay.
Right now having a pool to small will result in more files being opened,
(elf.Open) which results in lots of allocations and high CPU usage.
Hence we have a tradeoff of CPU + allocations vs heap usage.
Test Plan
Ran overnight without issues.
Signed-off-by: Francisco Javier Honduvilla Coto javierhonduco@gmail.com