pkg/cache: Fix data races #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix #1962 |
brancz
approved these changes
Sep 19, 2023
kakkoyun
reviewed
Sep 19, 2023
kakkoyun
reviewed
Sep 19, 2023
javierhonduco
force-pushed
the
cache-fix-races
branch
from
6a87b5a
to
7178dde
Compare
javierhonduco
commented
Sep 19, 2023
javierhonduco
commented
Sep 20, 2023
Get() modify state, for LRU bookeeping purposes, hence we need to use a writer lock. Stop spawning goroutines for every callback as this introduces other data races. Test Plan ========= The data races reported by tsan (make ENABLE_RACE=yes) are gone! Both Kemal and myself have ran this code with a very small object pool over night without any issues
javierhonduco
force-pushed
the
cache-fix-races
branch
from
7178dde
to
cbedfee
Compare
kakkoyun
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get() modify state, for LRU bookkeeping purposes, hence we need to use a writer lock.
Stop spawning goroutines for every callback as this introduces another data race.
Test Plan
The data races reported by tsan (make ENABLE_RACE=yes) are gone!
Both Kemal and myself have ran this code with a very small object pool
over night without any issues