Add support for Position Independent Code #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
force-pushed
the
pic_support
branch
from
de5584f
to
bfa82f4
Compare
kakkoyun
force-pushed
the
pic_support
branch
from
bfa82f4
to
c149982
Compare
kakkoyun
changed the title
brancz
reviewed
Feb 24, 2022
brancz
reviewed
Feb 24, 2022
brancz
reviewed
Feb 24, 2022
brancz
reviewed
Feb 24, 2022
brancz
reviewed
Feb 24, 2022
brancz
reviewed
Feb 24, 2022
brancz
reviewed
Feb 24, 2022
| } | ||
|
|
||
| func (f *ObjectFile) ObjAddr(addr uint64) (uint64, error) { | ||
| f.baseOnce.Do(func() { f.baseErr = f.computeBase(addr) }) |
There was a problem hiding this comment.
we already have the NewObjectFile function that we use to instantiate the struct, let's just do the computation there once
There was a problem hiding this comment.
In order to compute the base properly we need an address, that's why we need to defer the calculation until we received an address from the profiler.
brancz
reviewed
Feb 24, 2022
brancz
reviewed
Feb 24, 2022
brancz
reviewed
Feb 24, 2022
brancz
reviewed
Feb 24, 2022
| @@ -257,6 +318,7 @@ func (p *CgroupProfiler) profileLoop(ctx context.Context, now time.Time, counts, | |||
|
|
|||
| mapping := maps.NewMapping(p.pidMappingFileCache) | |||
| kernelMapping := &profile.Mapping{ | |||
| // TODO(kakkoyun): Check if this conflicts with https://github.com/google/pprof/pull/675/files | |||
9 tasks
|
There is a regression, in the branch. I'm trying to find it. Thus, I've marked it as draft again. |
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
brancz
approved these changes
Mar 3, 2022
kakkoyun
commented
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Fixes parca-dev/parca#326
also fixes #256 and #264