Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Don't scroll the table header #3688

Closed
metalmatze opened this issue Aug 25, 2023 · 6 comments
Closed

UI: Don't scroll the table header #3688

metalmatze opened this issue Aug 25, 2023 · 6 comments
Labels
area/ui Something about the UI enhancement New feature or request

Comments

@metalmatze
Copy link
Member

In the table visualization, the table header scrolls with the content.
Eventually, you might be so far down in the data, that it takes super long to scroll up to the table header again (to either read it or change the sorting).

We should make sure to only scroll the table body and never the table header.

brave_screenshot_local polarsignals com
@metalmatze metalmatze added enhancement New feature or request area/ui Something about the UI labels Aug 25, 2023
@metalmatze metalmatze changed the title UI: Table header doesn't scroll UI: Don't scroll the table header Aug 25, 2023
@karthick3018
Copy link

@metalmatze I can take this

@manojVivek
Copy link
Contributor

Hi @karthick3018, please go ahead, let us know if you have any questions.

karthick3018 pushed a commit to karthick3018/parca that referenced this issue Sep 19, 2023
updating table header position:parca-dev#3688
4b49085
@karthick3018 karthick3018 mentioned this issue Sep 19, 2023
Merged
@karthick3018
Copy link

karthick3018 commented Oct 21, 2023 •
edited

@manojVivek I guess you forgot one contributer in the list 🫠

@manojVivek
Copy link
Contributor

Sorry about that, thanks for the reminder! 😅

@manojVivek
Copy link
Contributor

@all-contributors Please add @karthick3018 for code.

@allcontributors allcontributors bot mentioned this issue Oct 25, 2023
Merged
@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @karthick3018! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ui Something about the UI enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metalmatze @manojVivek @karthick3018