Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating table header position:https://github.com/parca-dev/parca/iss… #3838

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

karthick3018
Copy link

it fixes issue #3688 by updating the table header position to sticky

@karthick3018 karthick3018 requested a review from a team as a code owner September 19, 2023 11:49
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Karthick Raja seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@brancz
Copy link
Member

brancz commented Sep 20, 2023

@karthick3018 we need you to sign the CLA to merge (it’s really just a one time DCO so you can also instead sign the commit if you prefer that, but by signing the cla you only have to do it once for all your contributions).

@brancz
Copy link
Member

brancz commented Sep 20, 2023

Otherwise lgtm

@karthick3018
Copy link
Author

@karthick3018 we need you to sign the CLA to merge (it’s really just a one time DCO so you can also instead sign the commit if you prefer that, but by signing the cla you only have to do it once for all your contributions).

yeah did already

@brancz
Copy link
Member

brancz commented Sep 20, 2023

Indeed, I can see it on the backend! Rekicking the PR, otherwise I'll just merge. Thank you very much for the contribution!

@brancz
Copy link
Member

brancz commented Sep 20, 2023

Ok I don't know why the PR status doesn't want to update, but since I can see the signature, we're all good.

@brancz brancz merged commit 4802c52 into parca-dev:main Sep 20, 2023
31 checks passed
@karthick3018 karthick3018 deleted the issue-table-header-scroll-3688 branch September 20, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants