pkg/profilestore: reject requests that have duplicate label names #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
heylongdacoder
commented
Sep 3, 2022
| @@ -466,8 +465,6 @@ mainLoop: | |||
| Value: l.Value, | |||
| }) | |||
| } | |||
| // Must ensure label-set is sorted | |||
| sort.Sort(tl) | |||
There was a problem hiding this comment.
since profilestore will sort the label-set, I think this can be removed?
Fixes: parca-dev#1461 Signed-off-by: heylongdacoder <heylongdacoder@gmail.com>
heylongdacoder
force-pushed
the
fix-1461
branch
from
833ff81
to
7c8d9a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1461
Signed-off-by: heylongdacoder heylongdacoder@gmail.com