ui: Fix escaped characters bug #2198
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| setLabelValues(response.labelValues); | ||
| // replace single `\` in the `labelValues` string with doubles `\\` if available. | ||
| const newValues = response.labelValues.map(value => | ||
| value.includes('\\') ? value.replace('\\', '\\\\') : value |
There was a problem hiding this comment.
I belive the string.replace will only replace the first matching pattern, so it wouldn't handle a second occurrence of \\ in the string.
I am not sure if multiple escape characters is a possibility here, but just in case.
There was a problem hiding this comment.
Also, Should we extract this into a sanitizeLabelValue function in @parca/functions package and use it?
There was a problem hiding this comment.
Yeah I just figured that was a possibility. making a change now
There was a problem hiding this comment.
It's great that the CodeQL scanner captured it too. 😀
|
is there a docker image / release I could use with this fix? |
|
Yep! There's always an image built from |
* ui: Fix escaped characters bug * Use `replaceAll` to switch characters * Fix linting errors Co-authored-by: Manoj Vivek <p.manoj.vivek@gmail.com>
This PR fixes a bug where an inclusion of escaped characters in the
parca.yamlfile causes the profiler not to work as expected. To fix, we replace single\in thelabelValuesstring with doubles\\if available and this is done on 3 levels:Resolves #1060