Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shareability fixes #2677

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Shareability fixes #2677

merged 3 commits into from
Mar 2, 2023

Conversation

monicawoj
Copy link
Contributor

This PR addresses two issues that we were encountering:

  1. Selected point in metrics graph & Flamegraph were not appearing despite this information being in the URL (shareability fix)
  2. Flamegraph was not being updated for delta type profiles on time selection in the metrics graph

@monicawoj monicawoj requested a review from a team as a code owner March 2, 2023 12:16
@monicawoj monicawoj changed the base branch from main to release-0.16 March 2, 2023 12:23
brancz
brancz approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Works perfectly now!

@brancz brancz merged commit 501bf54 into release-0.16 Mar 2, 2023
@brancz brancz deleted the shareability-fix branch March 2, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monicawoj @brancz