Add internal/trace from golang #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be awesome to get this reviewed/merged as a lot of other PRs that I would like to open depends on this. |
|
Could we add some automation on updating this? Otherwise stuff like this tends to get fragile quickly. |
|
👍 I'll do something like |
|
sounds good to me |
|
Done :) |
brancz
reviewed
May 13, 2020
| @@ -0,0 +1,825 @@ | |||
| // Copyright 2017 The Go Authors. All rights reserved. | |||
There was a problem hiding this comment.
I think github has a couple of magic headers that can be used to auto hide “generated” content. Do you mind adding one of those so the diff when we sync isn’t as huge to review as it is now?
There was a problem hiding this comment.
Done, looks like it's working :)
brancz
pushed a commit
that referenced
this pull request
Oct 5, 2021
pkg/storage: Move value chunks from tree nodes to a map in the series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently adding that package to
internal/trace, as I feel we shouldn't be exposing others author's packages for them. But if maintainers think it's more reasonable to make it non internal, then I can change the PR :)The only thing I actually added is README.md, so it makes sense to only review that :)
Ref #46