[WIP] Add traceui package from go cmd/trace #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What a great addition! +1 |
|
Now this PR builds ;) Sadly it's only partially copied from Go's repo. I will try to commit the patches upstream, but not sure if they will accept as it works fine for them in cli tool context, but doesn't work for us. To move forward I propose to merge as is. Thoughts? |
|
Have you proposed the changes to the go repo? If so then I'm not blocking this, but I want to at least get that process started. |
povilasv
changed the title
|
Not yet, will do and let you know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite edited version of https://golang.org/src/cmd/trace/ HTTP server.
I'll try to contribute my changes upstream, for now I purpose to merge this as is.
Ref: #46
depends on: #55