🙋 how to keep html name #280

songlipeng2003 · 2017-12-15T03:46:07Z

<!DOCTYPE html>
<html>
<head>
	<title>home page</title>
  <script src="./scripts/index.js"></script>
</head>
<body>
	<img src="./images/logo.png">

	<a href="page.html">Link</a>
</body>
</html>

this page will compile to

<!DOCTYPE html>
<html>
<head>
	<title>home page</title>
  <script src="/dist/c4f6ff1a9fe4f3634b9272ba1ddaaf50.js"></script>
</head>
<body>
	<img src="/dist/98d8f0da23c4c8c6fe7083e3f62c1fdf.png">

	<a href="/dist/2f84526286378f5180fc0841e2f1a1d9.html">Link</a>
</body>
</html>

I want to keep html name, my expectation：

<!DOCTYPE html>
<html>
<head>
	<title>home page</title>
  <script src="/dist/c4f6ff1a9fe4f3634b9272ba1ddaaf50.js"></script>
</head>
<body>
	<img src="/dist/98d8f0da23c4c8c6fe7083e3f62c1fdf.png">

	<a href="/dist/page.html">Link</a>
</body>
</html>

Please tell me how to config ?

Software	Version(s)
Parcel	1.2.0
Node	1.2.1
npm/Yarn
Operating System	macos

The text was updated successfully, but these errors were encountered:

philipodev · 2017-12-15T09:11:22Z

this is somewhat related to #270

DeMoorJasper · 2017-12-15T15:51:25Z

This shouldn't be a hard fix, related code:

parcel/src/Asset.js

Lines 146 to 166 in c008bb0

    
           generateBundleName(isMainAsset) { 
        
             // Resolve the main file of the package.json 
        
             let main = 
        
               this.package && this.package.main 
        
                 ? path.resolve(path.dirname(this.package.pkgfile), this.package.main) 
        
                 : null; 
        
             let ext = '.' + this.type; 
        
             // If this asset is main file of the package, use the package name 
        
             if (this.name === main) { 
        
               return this.package.name + ext; 
        
             } 
        
             // If this is the entry point of the root bundle, use the original filename 
        
             if (isMainAsset) { 
        
               return path.basename(this.name, path.extname(this.name)) + ext; 
        
             } 
        
             // Otherwise generate a unique name 
        
             return md5(this.name) + ext; 
        
           }

ssuman · 2017-12-15T17:58:28Z

Should I include this in my change ?

DeMoorJasper · 2017-12-15T18:00:16Z

@ssuman if you want, go for it :)

ssuman · 2017-12-15T18:04:18Z

Sure will include this in my PR.

Munter · 2017-12-25T23:03:19Z

In assetgraph-builder we also hash filenames, but exclude any files matching the following from renaming:

Any graph entry point (usually html)
Any asset linked to with an <a href>
Any asset linked to with a <meta http-equiv="refresh">
Serviceworkers (must keep consistent file name across builds)
humans.txt, robots.txt, '.htaccess`
Cache manifests, rss and atom feeds
favicon.ico

More rules might need to be added in the future of course, but these ones have covered us well for a couple of years

eirikb · 2018-01-17T14:58:50Z

Would it be possible to completely disable file name hashing with an option (to the cli)?

DeMoorJasper · 2018-01-17T18:23:08Z

@eirikb this will be hard as it will not be prone to overwriting. For example index.js and ./src/somefolder/index.js will both be saved to index.js but they should be different bundles. However it might be possible to use a relative path and use that to write bundles into a directory tree similar to the source one. I'm not sure what the specific usecase for this is though.
Also for production this seems like a bad strategy, as the bundle names can and probably will in the future invalidate cdn and browser cache by changing the name of the bundle based on content.

fregante · 2018-01-22T10:13:38Z

@DeMoorJasper the use case is having an actual site with human/SEO filenames, e.g.

example.com/
example.com/about.html
example.com/contacts.html

instead of

example.com/
example.com/98d8f0da23c4c8c6fe7083e3f62c1fdf.html <-- this looks so spammy
example.com/2f84526286378f5180fc0841e2f1a1d9.html

Munter · 2018-01-22T14:59:39Z

Having pages that can be linked to from the outside because of predictable URL' s is a pretty big use case. It's the core functionality of the web

DeMoorJasper · 2018-01-22T16:13:42Z

I kinda got aff-topic with my comment, talking about duplicates mainly focusing on javascript and such.
Anyways i understand the issue completely and agree this is a big issue. What do you guys think about something like this: (Pseudocode as explanation)

// HTML Asset getBundleName()
if (this.parent === null || this.parent.type === 'html') {
  // Only keep name if it's the main bundle or it's being required from html (for example through <a href=...
  // As this might possibly break if html is being used as a template inside JS, TS,...
  return path.join(this.relativePath, this.name);
}

This should only happen in htmlAssets (and maybe rawAsset - pictures and such) as far as i know

Munter · 2018-01-22T21:23:57Z

@DeMoorJasper If you only look at the parent, you'll get a bunch of static assets that could easily be content addressable, but keep their non-hashed file name. When you are finding the edges in the graph are you not also recording the type of edge it is? This is highly valuable information for knowing what to rename under which circumstances.

The rule about keeping names on entry points and anything pointed to by an html anchor is good. But there are a few more quite important assets not to rename. See #280 (comment)

opyate · 2018-02-28T11:24:00Z

Will this give me friendlier filenames to use with Angular 1.x directive templateUrl? Or, please point me to an example, as I can't find any.

devongovett · 2018-03-21T02:53:53Z

Should be solved by #1025 which retains filenames and folder structure for linked files, and content hashes static assets. Please help test using the master branch - a release will hopefully come next week!

HowardvanRooijen · 2020-06-02T21:34:08Z

In assetgraph-builder we also hash filenames, but exclude any files matching the following from renaming:

Any graph entry point (usually html)

Any asset linked to with an <a href>

Any asset linked to with a <meta http-equiv="refresh">

Serviceworkers (must keep consistent file name across builds)

humans.txt, robots.txt, '.htaccess`

Cache manifests, rss and atom feeds

favicon.ico

More rules might need to be added in the future of course, but these ones have covered us well for a couple of years

Hi,

You mention rss and atom feeds - do you know what the naming convention should be used to ensure these files are ignored?

Currently I am producing a rss.xml and atom.xml and both of these are being hashed.

Munter · 2020-06-03T13:47:20Z

I can only speak to what we did in assetgraph-builder. There we infer the asset type from the way it is marked up as a <link rel="alternate"> with a type attribute: https://github.com/assetgraph/assetgraph/blob/v6/lib/assets/Html.js#L477-L486

If you were to just anchorlink to the xml file it would just be inferred as an xml file with no special significance.

From looking at https://github.com/parcel-bundler/parcel/blob/master/packages/core/parcel-bundler/src/assets/HTMLAsset.js I can't see any similar special categorization of feeds and indeed https://github.com/parcel-bundler/parcel/tree/master/packages/core/parcel-bundler/src/assets also doesn't seem to have have any special handling. So in Parcel your feed is probably just treated equally to any other static asset with no special handling to keep urls stable

HowardvanRooijen · 2020-06-04T10:54:10Z

I currently have the following markup:

<link rel="alternate" type="application/atom+xml" href="/atom.xml" />
<link rel="alternate" type="application/rss+xml" href="/rss.xml" />

Which is being transformed into:

<link rel="alternate" type="application/atom+xml" href="/atom.c4df4b4f.xml">
<link rel="alternate" type="application/rss+xml" href="/rss.9a4ebc87.xml">

Which is less than ideal. I've read everything I could find, but I've not found a way to exclude these files. Any suggestions?

Many thanks!

ghost · 2021-09-13T05:37:05Z

This shouldn't be a hard fix, related code:

parcel/src/Asset.js

Lines 146 to 166 in c008bb0

generateBundleName(isMainAsset) {

// Resolve the main file of the package.json

let main =

this.package && this.package.main

? path.resolve(path.dirname(this.package.pkgfile), this.package.main)

: null;

let ext = '.' + this.type;

// If this asset is main file of the package, use the package name

if (this.name === main) {

return this.package.name + ext;

}

// If this is the entry point of the root bundle, use the original filename

if (isMainAsset) {

return path.basename(this.name, path.extname(this.name)) + ext;

}

// Otherwise generate a unique name

return md5(this.name) + ext;

}

where am I suppose to add this piece of code?

DeMoorJasper added 🙋‍♀️ Feature Good First Issue labels Dec 15, 2017

DeMoorJasper changed the title ~~how to keep html name~~ 🙋 how to keep html name Dec 15, 2017

Olian04 mentioned this issue Dec 15, 2017

🙋 PWA support #301

Closed

ssuman mentioned this issue Dec 16, 2017

[WIP] Keep file names #307

Closed

zeakd mentioned this issue Dec 29, 2017

🙋 Keep folder structure and filename #433

Closed

Munter mentioned this issue Feb 14, 2018

🙋 Use MD5 of File Content As Name To Bust Caches #717

Closed

devongovett mentioned this issue Feb 20, 2018

[RFC] File naming strategy #872

Closed

devongovett closed this as completed Mar 21, 2018

ancientaccount mentioned this issue Apr 29, 2018

Keep .html files for SEO? #1264

Closed

fregante mentioned this issue Jun 29, 2022

WebExtension shouldn't rename options.html #8130

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🙋 how to keep html name #280

🙋 how to keep html name #280

songlipeng2003 commented Dec 15, 2017

philipodev commented Dec 15, 2017

DeMoorJasper commented Dec 15, 2017 •

edited

Loading

ssuman commented Dec 15, 2017

DeMoorJasper commented Dec 15, 2017

ssuman commented Dec 15, 2017

Munter commented Dec 25, 2017

eirikb commented Jan 17, 2018

DeMoorJasper commented Jan 17, 2018 •

edited

Loading

fregante commented Jan 22, 2018

Munter commented Jan 22, 2018

DeMoorJasper commented Jan 22, 2018 •

edited

Loading

Munter commented Jan 22, 2018

opyate commented Feb 28, 2018

devongovett commented Mar 21, 2018

HowardvanRooijen commented Jun 2, 2020

Munter commented Jun 3, 2020 •

edited

Loading

HowardvanRooijen commented Jun 4, 2020

ghost commented Sep 13, 2021

🙋 how to keep html name #280

🙋 how to keep html name #280

Comments

songlipeng2003 commented Dec 15, 2017

philipodev commented Dec 15, 2017

DeMoorJasper commented Dec 15, 2017 • edited Loading

ssuman commented Dec 15, 2017

DeMoorJasper commented Dec 15, 2017

ssuman commented Dec 15, 2017

Munter commented Dec 25, 2017

eirikb commented Jan 17, 2018

DeMoorJasper commented Jan 17, 2018 • edited Loading

fregante commented Jan 22, 2018

Munter commented Jan 22, 2018

DeMoorJasper commented Jan 22, 2018 • edited Loading

Munter commented Jan 22, 2018

opyate commented Feb 28, 2018

devongovett commented Mar 21, 2018

HowardvanRooijen commented Jun 2, 2020

Munter commented Jun 3, 2020 • edited Loading

HowardvanRooijen commented Jun 4, 2020

ghost commented Sep 13, 2021

DeMoorJasper commented Dec 15, 2017 •

edited

Loading

DeMoorJasper commented Jan 17, 2018 •

edited

Loading

DeMoorJasper commented Jan 22, 2018 •

edited

Loading

Munter commented Jun 3, 2020 •

edited

Loading