WIP: Don't serve on non html main assets #1088
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #1005.
I currently do a strict check, whether the main entry asset has the
.html
file extension or not.I don't know if anyone still does this today, but this would fail on
.htm
or.html5
main files.This could be solved using a RegExp, like e.g.
/htm|html|html5/
.But is it intended to support
.hbs
or other template language files as main assets?I'd be happy if anyone has a suggestion / tip for this problem.
Regards
Nico