Don't start server if target isn't browser #1204
Conversation
DeMoorJasper
changed the title
src/Bundler.js
Outdated
| @@ -643,7 +643,9 @@ class Bundler extends EventEmitter { | |||
| } | |||
|
|
|||
| async serve(port = 1234, https = false) { | |||
| this.server = await Server.serve(this, port, https); | |||
| if (this.options.target === 'browser') { | |||
There was a problem hiding this comment.
I think we should move this check into the CLI specifically. If someone is using the Parcel API, and they call serve, we should always start a server even if the target is node. In the CLI, we can detect the target and just call bundle instead of serve there.
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
==========================================
- Coverage 88.28% 87.38% -0.91%
==========================================
Files 77 77
Lines 4355 4113 -242
==========================================
- Hits 3845 3594 -251
- Misses 510 519 +9
Continue to review full report at Codecov.
|
src/cli.js
Outdated
|
|
||
| if ( | ||
| (command.name() === 'serve' && command.target === undefined) || | ||
| 'browser' |
There was a problem hiding this comment.
not sure I understand this logic
There was a problem hiding this comment.
that should've been
if (command.name() === 'serve' &&
command.target === (undefined || 'browser')) {
// Start server
}guess I made a typo, but fixed it now
|
Not sure this is the right way to go. I use |
|
HMR still starts in watch mode. serve mode is just for running a web server as well. |
Closes #1088 Closes #1202 Closes #1005