fix build not exiting in dev env #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When NODE_ENV is set to something else instead of `production` build was not exiting. This bug was intruduced in 1b6a93f commit
DeMoorJasper
approved these changes
Jun 30, 2018
devongovett
requested changes
Jun 30, 2018
src/cli.js
Outdated
| @@ -177,6 +177,7 @@ async function bundle(main, command) { | |||
| const Bundler = require('../'); | |||
|
|
|||
| if (command.name() === 'build') { | |||
| command.watch = false; | |||
There was a problem hiding this comment.
I think we should set command.production = true here actually, which would implicitly disable watching as well. I believe #1600 was meant to keep environment variables as set by the user, not control actual build. That can be done with other command line flags, e.g. if you want to disable minification, use --no-minify.
|
FYI |
2zH
pushed a commit
to 2zH/parcel
that referenced
this pull request
Jul 11, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NODE_ENV is set to something else instead of
productionbuild wasnot exiting. This bug was introduced in 1b6a93f
Closes #1626