Fix export namespace of an excluded asset #4220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
changed the title
mischnic
changed the title
Benchmark Resultspackages/benchmarks/three ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
packages/benchmarks/kitchen-sink ✅
Timings
Cold Bundles
Cached Bundles
packages/benchmarks/react-hn ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
packages/benchmarks/ak-editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
wbinnssmith
approved these changes
Feb 25, 2020
mischnic
force-pushed
the
wildcard-excluded
branch
5 times, most recently
from
ac16275
to
b23482c
Compare
Should it have been excluded though? Seems like if later code is referencing it, then maybe excluding it was wrong? Probably misunderstanding. |
mischnic
force-pushed
the
wildcard-excluded
branch
2 times, most recently
from
4810963
to
77d7f0d
Compare
mischnic
force-pushed
the
wildcard-excluded
branch
from
77d7f0d
to
0fec5a4
Compare
Well, symbols in // index.js
export * from "./exports";
export const Main = "main";
// exports.js
export { a } from "./version";
export { b } from "./version2";
// version(2) just export a variableThe big questions: should we not emit the helper function is possible :? (function(){
function $parcel$exportWildcard(dest, source) {
Object.keys(source).forEach(function (key) {
if (key === 'default' || key === '__esModule') {
return;
}
Object.defineProperty(dest, key, {
enumerable: true,
get: function get() {
return source[key];
}
});
});
return dest;
}
// ASSET: /Users/niklas/Documents/_dev/_git/parcel/parcel/packages/core/integration-tests/test/integration/scope-hoisting/es6/import-namespace-sideEffects/other/index.js
var $e367b6edc7f6de5eef03bc6e42a99$exports = {};
// ASSET: /Users/niklas/Documents/_dev/_git/parcel/parcel/packages/core/integration-tests/test/integration/scope-hoisting/es6/import-namespace-sideEffects/other/exports.js
var $d52a61ca40f5bad1d825ae05f8$exports = {};
var $e7fabb81ca3e1f1a1428a4a075efc$export$a = "foo";
var $c295ce722e44b4d388a0f05140b040$export$b = "bar";
$d52a61ca40f5bad1d825ae05f8$exports.a = $e7fabb81ca3e1f1a1428a4a075efc$export$a;
$d52a61ca40f5bad1d825ae05f8$exports.b = $c295ce722e44b4d388a0f05140b040$export$b;
$parcel$exportWildcard($e367b6edc7f6de5eef03bc6e42a99$exports, $d52a61ca40f5bad1d825ae05f8$exports);
const $e367b6edc7f6de5eef03bc6e42a99$export$Main = "main";
$e367b6edc7f6de5eef03bc6e42a99$exports.Main = $e367b6edc7f6de5eef03bc6e42a99$export$Main;
output = $e367b6edc7f6de5eef03bc6e42a99$exports;
})();output with this change: (function(){
// ASSET: /Users/niklas/Documents/_dev/_git/parcel/parcel/packages/core/integration-tests/test/integration/scope-hoisting/es6/import-namespace-sideEffects/other/exports.js
// ASSET: /Users/niklas/Documents/_dev/_git/parcel/parcel/packages/core/integration-tests/test/integration/scope-hoisting/es6/import-namespace-sideEffects/other/version.js
var $e7fabb81ca3e1f1a1428a4a075efc$export$a = "foo";
var $c295ce722e44b4d388a0f05140b040$export$b = "bar";
// ASSET: /Users/niklas/Documents/_dev/_git/parcel/parcel/packages/core/integration-tests/test/integration/scope-hoisting/es6/import-namespace-sideEffects/other/index.js
var $e367b6edc7f6de5eef03bc6e42a99$exports = {};
$e367b6edc7f6de5eef03bc6e42a99$exports.a = $e7fabb81ca3e1f1a1428a4a075efc$export$a;
$e367b6edc7f6de5eef03bc6e42a99$exports.b = $c295ce722e44b4d388a0f05140b040$export$b;
const $e367b6edc7f6de5eef03bc6e42a99$export$Main = "main";
$e367b6edc7f6de5eef03bc6e42a99$exports.Main = $e367b6edc7f6de5eef03bc6e42a99$export$Main;
output = $e367b6edc7f6de5eef03bc6e42a99$exports;
})(); |
wbinnssmith
reviewed
Mar 4, 2020
wbinnssmith
force-pushed
the
wildcard-excluded
branch
from
f999ab9
to
44f0ddb
Compare
devongovett
reviewed
Mar 21, 2020
| @@ -438,6 +459,86 @@ export function link({ | |||
| ); | |||
| let mod = nullthrows(bundleGraph.getDependencyResolution(dep, bundle)); | |||
| path.replaceWith(t.valueToNode(mod.id)); | |||
| } else if (callee.name === '$parcel$exportAll') { | |||
There was a problem hiding this comment.
Not sure I totally understand why this is necessary vs the old $parcel$exportWildcard with a $parcelRequire inside. Seems like a bunch of logic got duplicated?
|
This is indeed a giant hack and way too complex, let's do #4387 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Closes #4216
An asset with
export * from ...might be excluded byconcat, so the exportsSpecifier will be undefined (so$parcel$exportWildcard(something, ReexportingExportsSpecifier)doesn't work).Solution: don't emit
$parcel$exportWildcardif the imported asset is a ES6 module, in which casebundleGraph.getExportedSymbols(mod)are traversed and assignments emitted.cc @wbinnssmith, does this fix your problem?