Don't exclude assets that were imported with a namespace #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark Resultspackages/benchmarks/three 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... packages/benchmarks/kitchen-sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... packages/benchmarks/react-hn 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... packages/benchmarks/ak-editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
wbinnssmith
approved these changes
Mar 26, 2020
mischnic
force-pushed
the
wildcard-excluded2
branch
2 times, most recently
from
30146eb
to
a6ae32f
Compare
mischnic
force-pushed
the
wildcard-excluded2
branch
from
a6ae32f
to
11182f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Supersedes #4220
Closes #4216
Don't exclude assets that were imported with a namespace because they themselves might be needed
This also fixes namespace reexports of excluded assets
We might be able to optimize this further in the future when we have better knowledge of symbols in the bundle graph (#4375)
💻 Examples
Doing a wildcard import of this (with
sideEffects: false)would make
Maindisappear because the identifier of that very asset is missing an d was replaced with an empty object:$parcel$exportWildcard(..., {}).cc @wbinnssmith