[T-6] Image transformer #4881
Merged
[T-6] Image transformer #4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to and will mark 1 task as "Done" when merged:
|
DeMoorJasper
requested review from
devongovett,
wbinnssmith,
mischnic and
padmaia
and removed request for
devongovett and
wbinnssmith
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
devongovett
reviewed
Jul 18, 2020
devongovett
reviewed
Jul 21, 2020
| @@ -32,6 +32,7 @@ | |||
| "script:*.vue": ["@parcel/transformer-vue"], | |||
| "style:*.vue": ["@parcel/transformer-vue"], | |||
| "custom:*.vue": ["@parcel/transformer-vue"], | |||
| "url:*.{png,jpg,jpeg,webp}": ["@parcel/transformer-image", "..."], | |||
There was a problem hiding this comment.
hmm so now you couldn't use it from CSS/HTML without the url: prefix either... :/
There was a problem hiding this comment.
that's probably why I originally did it without the url: prefix...
There was a problem hiding this comment.
so should I change it back?
devongovett
approved these changes
Aug 3, 2020
| : undefined; | ||
| let format = asset.query.as ? asset.query.as.toLowerCase().trim() : null; | ||
|
|
||
| let imagePipeline = sharp(inputBuffer); |
There was a problem hiding this comment.
If none of the options are set, should we skip running sharp altogether? Maybe faster?
There was a problem hiding this comment.
But the output might be non minified
There was a problem hiding this comment.
Hmm it's not an optimizer... I guess we could check that option too. I was more thinking in dev it might be slow/unnecessary.
There was a problem hiding this comment.
Yeah... I can fix that in a follow-up PR if you want, sharp isn't always smaller anyway, I've had a couple cases in which it significantly enlarged output images... (on personal/work projects)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Allow resizing of images using query parameters and sharp
Closes #3737
Closes #3736
Closes #3477
Closes T-6
💻 Examples
🚨 Test instructions
Run kitchen sink example
✔️ PR Todo