Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle reference named pipeline fix and query params fix #5228

Merged
merged 13 commits into from
Nov 22, 2020
Merged

Bundle reference named pipeline fix and query params fix #5228

merged 13 commits into from
Nov 22, 2020

Conversation

DeMoorJasper
Copy link
Member

↪️ Pull Request

This PR is based on #5219 with additional bugfixes and tests for getURLReplacement

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

rhendric and others added 4 commits October 6, 2020 20:53
@rhendric
Partially fix asset query handling
d558d86 
The test case for an image referenced from HTML is broken for now; there seems
to be a deeper conflict with assets in named pipelines and some aspect of the
HTML pipeline.
@DeMoorJasper
Merge branch 'v2' into rhendric/asset-query-property
384dec4
@DeMoorJasper
Merge branch 'v2' into rhendric/asset-query-property
b5140e6
@DeMoorJasper
add tests and fix bug when using bundle references with query params …
79c994d 
…and/or named pipelines
@height
Copy link

height bot commented Oct 11, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@DeMoorJasper DeMoorJasper mentioned this pull request Oct 11, 2020
Closed
3 tasks
@parcel-benchmark
Copy link

parcel-benchmark commented Oct 11, 2020 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 11.81s -311.00ms
Cached 2.50s -201.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 271.00ms -87.00ms 🚀
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 432.00ms +136.00ms ⚠️
dist/legacy/index.dc3d7ad2.js 1.10kb +0.00b 3.54s -334.00ms 🚀
dist/legacy/index.html 701.00b +0.00b 3.72s -315.00ms 🚀
dist/legacy/index.afdbda6b.css 77.00b +0.00b 3.35s -311.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 1.84s -279.00ms 🚀
dist/legacy/index.dc3d7ad2.js 1.10kb +0.00b 2.12s -169.00ms 🚀
dist/modern/index.9c5edbbf.js 1.10kb +0.00b 2.12s -121.00ms 🚀
dist/legacy/index.html 701.00b +0.00b 2.07s -168.00ms 🚀
dist/modern/index.html 701.00b +0.00b 1.98s -256.00ms 🚀
dist/legacy/index.afdbda6b.css 77.00b +0.00b 2.07s -168.00ms 🚀
dist/modern/index.ef3960f9.css 77.00b +0.00b 1.98s -175.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 46.04s -1.03s
Cached 2.60s +48.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/logo.24c8bf9e.png 274.00b +0.00b 173.00ms -51.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 478.31kb +0.00b 1.63s +156.00ms ⚠️
dist/PermalinkedComment.db77afbe.js 4.22kb +0.00b 1.63s +157.00ms ⚠️
dist/UserProfile.ef6d6d51.js 1.70kb +0.00b 1.63s +157.00ms ⚠️
dist/NotFound.0b6210fa.js 532.00b +0.00b 1.63s +157.00ms ⚠️
dist/logo.24c8bf9e.png 274.00b +0.00b 1.50s +135.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 4.78m -7.78s
Cached 7.65s -66.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.bdbe5bb0.js 2.33mb +6.00b ⚠️ 2.39m -11.52s 🚀
dist/EmojiPickerComponent.0d4c4f30.js 139.08kb +0.00b 19.78s -1.81s 🚀
dist/component.3f6c5fd5.js 30.87kb +0.00b 5.93s -1.19s 🚀
dist/DatePicker.69def134.js 21.16kb +0.00b 19.77s -1.81s 🚀
dist/dropzone.4e408093.js 16.19kb +0.00b 2.39m +50.30s ⚠️
dist/workerHasher.9a1bcc26.js 11.90kb +0.00b 22.16s -2.21m 🚀
dist/component.887889bd.js 6.27kb +0.00b 12.41s -2.01s 🚀
dist/EmojiPickerComponent.fc1dc3f2.js 3.68kb +0.00b 22.16s -2.21m 🚀
dist/index.6d011607.css 3.46kb +0.00b 1.74m -15.18s 🚀
dist/dropzone.e88efb33.js 3.44kb +0.00b 54.28s -32.70s 🚀
dist/Modal.6d0dd03d.js 3.15kb +0.00b 5.92s -1.20s 🚀
dist/16.c290a944.js 2.49kb +0.00b 6.77s -1.30s 🚀
dist/date.e4800c83.js 1.96kb +0.00b 2.38m +2.17m ⚠️
dist/feedback.6a6b2f29.js 1.86kb +0.00b 19.75s +5.97s ⚠️
dist/16.341477eb.js 1.79kb +0.00b 1.30m -19.66s 🚀
dist/heading6.238921eb.js 1.53kb +0.00b 19.75s +5.97s ⚠️
dist/16.800e2eff.js 1.46kb +0.00b 12.41s -2.01s 🚀
dist/16.65ce2e2d.js 1.45kb +0.00b 5.92s -1.20s 🚀
dist/expand.b1a7b9be.js 1.38kb +0.00b 19.77s -1.81s 🚀
dist/16.fccb8e14.js 1.34kb +0.00b 5.92s -1.20s 🚀
dist/16.39730f48.js 1.27kb +0.00b 5.92s -1.20s 🚀
dist/16.d0ab6e68.js 1.26kb +0.00b 12.41s -2.01s 🚀
dist/divider.dfbacd71.js 1.25kb +0.00b 2.38m +2.17m ⚠️
dist/component.191770ee.js 1.23kb +0.00b 6.77s -1.30s 🚀
dist/16.05bc118a.js 1.23kb +0.00b 6.77s -1.30s 🚀
dist/decision.06aab825.js 1.21kb +0.00b 2.38m +2.17m ⚠️
dist/simpleHasher.96471d3f.js 755.00b +0.00b 22.16s -2.21m 🚀
dist/index.html 119.00b +0.00b 9.59s -1.15s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.c7a3810f.js 2.30mb +0.00b 786.00ms -47.00ms 🚀
dist/Modal.c9cf25e7.js 38.79kb +0.00b 834.00ms -226.00ms 🚀
dist/component.887889bd.js 6.27kb +0.00b 955.00ms +52.00ms ⚠️
dist/Modal.6d0dd03d.js 3.15kb +0.00b 1.02s +186.00ms ⚠️
dist/16.c290a944.js 2.49kb +0.00b 787.00ms -46.00ms 🚀
dist/date.e4800c83.js 1.96kb +0.00b 1.09s +74.00ms ⚠️
dist/16.337c4a69.js 1.86kb +0.00b 1.05s +95.00ms ⚠️
dist/16.341477eb.js 1.79kb +0.00b 1.03s +94.00ms ⚠️
dist/code.bc8fb460.js 1.61kb +0.00b 1.09s +74.00ms ⚠️
dist/16.ba59f551.js 1.51kb +0.00b 1.04s +90.00ms ⚠️
dist/16.800e2eff.js 1.46kb +0.00b 1.03s +94.00ms ⚠️
dist/16.dc943e90.js 1.46kb +0.00b 1.04s +104.00ms ⚠️
dist/16.f4d9f154.js 1.44kb +0.00b 1.06s +88.00ms ⚠️
dist/16.a2715aa7.js 1.40kb +0.00b 1.06s +83.00ms ⚠️
dist/16.ca13f983.js 1.36kb +0.00b 1.06s +82.00ms ⚠️
dist/16.2bcd6143.js 1.32kb +0.00b 1.06s +83.00ms ⚠️
dist/16.4d03606f.js 1.31kb +0.00b 1.09s +74.00ms ⚠️
dist/16.b3d19690.js 1.27kb +0.00b 1.04s +90.00ms ⚠️
dist/16.2a859487.js 1.26kb +0.00b 1.03s +94.00ms ⚠️
dist/16.8b45a9b4.js 1.26kb +0.00b 1.05s +91.00ms ⚠️
dist/16.12b6f2f5.js 1.26kb +0.00b 1.04s +90.00ms ⚠️
dist/16.d0ab6e68.js 1.26kb +0.00b 1.03s +94.00ms ⚠️
dist/component.191770ee.js 1.23kb +0.00b 786.00ms -47.00ms 🚀
dist/action.6beade63.js 1.23kb +0.00b 1.09s +74.00ms ⚠️
dist/16.05bc118a.js 1.23kb +0.00b 787.00ms -46.00ms 🚀
dist/decision.06aab825.js 1.21kb +0.00b 1.09s +75.00ms ⚠️
dist/16.9f329251.js 1.18kb +0.00b 1.06s +83.00ms ⚠️
dist/index.html 119.00b +0.00b 546.00ms -87.00ms 🚀

Three.js x4 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Click here to view a detailed benchmark overview.

@devongovett
Copy link
Member

Any idea if this is related to #4498 or #4856?

@DeMoorJasper
Copy link
Member Author

@devongovett not sure, would have to try it out

@DeMoorJasper
Copy link
Member Author

DeMoorJasper commented Nov 22, 2020 •
edited
Loading

@devongovett just checked, it does not fix those issues.
But it does however fix the issue described in #5219 as well as improve and add a bunch of test for some utils

@mischnic
Copy link
Member

#4856 would be fixed by #4842

@DeMoorJasper @devongovett
Update packages/core/core/src/requests/PathRequest.js
4f1374d 
Co-authored-by: Devon Govett <devongovett@gmail.com>
@devongovett devongovett merged commit 6b1aec6 into v2 Nov 22, 2020
@devongovett devongovett deleted the bundle-reference-query-fixes branch November 22, 2020 21:14
AGawrys pushed a commit to AGawrys/parcel that referenced this pull request Dec 1, 2020
@DeMoorJasper @AGawrys
Bundle reference named pipeline fix and query params fix (parcel-bund…
6f95ae8 
…ler#5228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhendric rhendric rhendric left review comments

@devongovett devongovett devongovett approved these changes

@wbinnssmith wbinnssmith Awaiting requested review from wbinnssmith

@mischnic mischnic Awaiting requested review from mischnic

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DeMoorJasper @parcel-benchmark @devongovett @mischnic @rhendric