Bump emphasize #5483

mischnic · 2020-12-15T15:59:19Z

height · 2020-12-15T15:59:23Z

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

parcel-benchmark · 2020-12-15T16:29:49Z

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	2.89s	+38.00ms
Cached	577.00ms	+34.00ms ⚠️

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/modern/parcel.d5807e82.webp	102.94kb	+0.00b	630.00ms	+50.00ms ⚠️
dist/modern/index.f81b5b4b.js	1.11kb	+0.00b	639.00ms	+40.00ms ⚠️
dist/modern/index.html	701.00b	+0.00b	639.00ms	+40.00ms ⚠️

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.d5807e82.webp	102.94kb	+0.00b	59.00ms	+5.00ms ⚠️
dist/modern/parcel.d5807e82.webp	102.94kb	+0.00b	58.00ms	-16.00ms 🚀
dist/legacy/index.9ff7c523.js	1.11kb	+0.00b	59.00ms	-16.00ms 🚀
dist/modern/index.f81b5b4b.js	1.11kb	+0.00b	80.00ms	+6.00ms ⚠️
dist/legacy/index.html	701.00b	+0.00b	59.00ms	+4.00ms ⚠️
dist/modern/index.html	701.00b	+0.00b	59.00ms	-16.00ms 🚀
dist/legacy/index.5859ab37.css	77.00b	+0.00b	59.00ms	+4.00ms ⚠️
dist/modern/index.77ce15d4.css	77.00b	+0.00b	59.00ms	-15.00ms 🚀

React HackerNews ✅

Timings

Description	Time	Difference
Cold	19.46s	-130.00ms
Cached	8.64s	+338.00ms

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/PermalinkedComment.1964b8bb.js	4.20kb	+0.00b	902.00ms	+173.00ms ⚠️
dist/UserProfile.f5fa9f60.js	1.76kb	+0.00b	902.00ms	+173.00ms ⚠️
dist/NotFound.f4adce8d.js	530.00b	+0.00b	216.00ms	+13.00ms ⚠️
dist/logo.24c8bf9e.png	274.00b	+0.00b	490.00ms	-31.00ms 🚀

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/logo.24c8bf9e.png	274.00b	+0.00b	60.00ms	+5.00ms ⚠️

AtlasKit Editor ✅

Timings

Description	Time	Difference
Cold	2.07m	+7.65s ⚠️
Cached	2.85s	-2.00ms

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/index.49febfe6.js	2.46mb	+0.00b	1.02m	-4.49s 🚀
dist/pdfRenderer.1c87caa3.js	1.11mb	+0.00b	37.19s	-3.56s 🚀
dist/editorView.94307fd1.js	587.53kb	+0.00b	1.23m	+18.75s ⚠️
dist/popup.f5b54d01.js	169.25kb	+0.00b	14.58s	-1.15s 🚀
dist/media-viewer.b4647ff4.js	72.87kb	+0.00b	10.25s	-1.88s 🚀
dist/card.92b0f4f9.js	54.02kb	+0.00b	8.35s	-1.74s 🚀
dist/card.43bef276.js	51.77kb	+0.00b	12.25s	-1.30s 🚀
dist/Modal.507a0880.js	39.18kb	+0.00b	3.98s	-1.50s 🚀
dist/component.e862677c.js	30.82kb	+0.00b	1.72s	-1.20s 🚀
dist/esm.572878ca.js	27.67kb	+0.00b	8.00s	-1.70s 🚀
dist/component.c1c3a8ff.js	22.54kb	+0.00b	3.98s	-1.63s 🚀
dist/DatePicker.64b5aa93.js	21.20kb	+0.00b	5.30s	-4.28s 🚀
dist/smartMediaEditor.ab51c6dd.js	16.85kb	+0.00b	13.22s	-2.68s 🚀
dist/js.63570256.js	16.55kb	+0.00b	3.96s	+944.00ms ⚠️
dist/dropzone.491f3481.js	16.06kb	+0.00b	14.57s	-994.00ms 🚀
dist/ui.bfd5ec70.js	14.21kb	+0.00b	10.68s	+1.10s ⚠️
dist/component.dd6e8cc9.js	6.20kb	+0.00b	3.38s	-2.24s 🚀
dist/card.89465567.js	5.71kb	+0.00b	9.98s	-2.13s 🚀
dist/EmojiPickerComponent.5d345edd.js	3.62kb	+0.00b	10.68s	+2.96s ⚠️
dist/png-chunks-extract.8c8d635d.js	3.55kb	+0.00b	3.96s	-1.65s 🚀
dist/index.10f02a5e.css	3.46kb	+0.00b	17.28s	-23.49s 🚀
dist/dropzone.c3746b5e.js	3.44kb	+0.00b	14.54s	+2.99s ⚠️
dist/Modal.19c70720.js	3.14kb	+0.00b	3.00s	+274.00ms ⚠️
dist/clipboard.84ebdbd2.js	2.97kb	+0.00b	12.16s	-3.46s 🚀
dist/16.624bbe22.js	2.49kb	+0.00b	1.71s	-424.00ms 🚀
dist/ResourcedEmojiComponent.470ee09d.js	2.15kb	+0.00b	10.68s	+2.95s ⚠️
dist/date.57372c70.js	1.96kb	+0.00b	4.27s	+386.00ms ⚠️
dist/images.c36248a4.js	1.90kb	+0.00b	4.43s	+535.00ms ⚠️
dist/feedback.80c8a178.js	1.86kb	+0.00b	5.20s	+748.00ms ⚠️
dist/16.342e69d2.js	1.86kb	+0.00b	4.16s	+646.00ms ⚠️
dist/browser.00e50e54.js	1.82kb	+0.00b	12.16s	-3.54s 🚀
dist/16.d173f3df.js	1.79kb	+0.00b	3.54s	+433.00ms ⚠️
dist/workerHasher.f1855576.js	1.75kb	+0.00b	7.90s	-1.67s 🚀
dist/list-number.9bb92c49.js	1.68kb	+0.00b	4.44s	+403.00ms ⚠️
dist/status.acecc9f0.js	1.68kb	+0.00b	4.65s	+354.00ms ⚠️
dist/code.6d1ec8ce.js	1.61kb	+0.00b	4.27s	+594.00ms ⚠️
dist/link.cda9435d.js	1.53kb	+0.00b	4.44s	+407.00ms ⚠️
dist/heading6.f14573d2.js	1.53kb	+0.00b	5.20s	+748.00ms ⚠️
dist/heading3.dede5b4c.js	1.51kb	+0.00b	5.25s	+806.00ms ⚠️
dist/16.9e858e4a.js	1.51kb	+0.00b	4.13s	+869.00ms ⚠️
dist/16.adfefbb7.js	1.46kb	+0.00b	3.54s	+433.00ms ⚠️
dist/16.23a6fba4.js	1.46kb	+0.00b	4.13s	+876.00ms ⚠️
dist/emoji.5072e4af.js	1.45kb	+0.00b	4.43s	+535.00ms ⚠️
dist/16.186663a4.js	1.45kb	+0.00b	1.71s	-1.21s 🚀
dist/16.2c3c2005.js	1.44kb	+0.00b	4.59s	+909.00ms ⚠️
dist/16.45c1cffe.js	1.40kb	+0.00b	4.59s	+909.00ms ⚠️
dist/heading5.fe670803.js	1.40kb	+0.00b	5.20s	+748.00ms ⚠️
dist/expand.739e3b88.js	1.38kb	+0.00b	5.22s	-4.35s 🚀
dist/16.8ff06a1d.js	1.36kb	+0.00b	4.16s	+646.00ms ⚠️
dist/16.263c691c.js	1.34kb	+0.00b	1.71s	-1.21s 🚀
dist/heading2.5c4ee285.js	1.33kb	+0.00b	5.25s	+953.00ms ⚠️
dist/16.b7512655.js	1.32kb	+0.00b	4.17s	+651.00ms ⚠️
dist/16.262b91f7.js	1.31kb	+0.00b	4.59s	+907.00ms ⚠️
dist/mention.76dc783a.js	1.29kb	+0.00b	4.55s	+511.00ms ⚠️
dist/heading4.8bbff8c5.js	1.29kb	+0.00b	5.25s	+806.00ms ⚠️
dist/Modal.d58fb436.js	1.28kb	+0.00b	3.96s	+949.00ms ⚠️
dist/16.436e2680.js	1.27kb	+0.00b	1.71s	-424.00ms 🚀
dist/layout.d9b11ad1.js	1.27kb	+0.00b	4.43s	+396.00ms ⚠️
dist/16.eaa9cadb.js	1.27kb	+0.00b	4.16s	+648.00ms ⚠️
dist/16.06e8a68f.js	1.26kb	+0.00b	3.95s	+694.00ms ⚠️
dist/16.19a76383.js	1.26kb	+0.00b	4.13s	+876.00ms ⚠️
dist/16.e5432caf.js	1.26kb	+0.00b	4.44s	+1.18s ⚠️
dist/16.62eaafc3.js	1.26kb	+0.00b	3.54s	+439.00ms ⚠️
dist/divider.2e62a51b.js	1.25kb	+0.00b	4.30s	+410.00ms ⚠️
dist/quote.487996a9.js	1.25kb	+0.00b	4.65s	+354.00ms ⚠️
dist/component.3edf7abd.js	1.23kb	+0.00b	3.00s	+275.00ms ⚠️
dist/action.8161ba48.js	1.23kb	+0.00b	4.27s	+594.00ms ⚠️
dist/16.0629cb86.js	1.23kb	+0.00b	3.00s	+275.00ms ⚠️
dist/decision.cdcb6e3b.js	1.21kb	+0.00b	4.30s	+415.00ms ⚠️
dist/panel-warning.8b68f633.js	1.21kb	+0.00b	5.18s	+1.01s ⚠️
dist/16.cd483156.js	1.18kb	+0.00b	4.17s	+651.00ms ⚠️
dist/list.e0e1a7a9.js	1.18kb	+0.00b	4.55s	+511.00ms ⚠️
dist/heading1.a939a2da.js	1.18kb	+0.00b	4.66s	+357.00ms ⚠️
dist/panel-error.210bc7a0.js	1.11kb	+0.00b	4.55s	+375.00ms ⚠️
dist/panel.8b5546b1.js	1.10kb	+0.00b	4.65s	+478.00ms ⚠️
dist/table.4e67906a.js	1.09kb	+0.00b	4.66s	+357.00ms ⚠️
dist/panel-success.a2e1eac9.js	1.05kb	+0.00b	4.55s	+374.00ms ⚠️
dist/panel-note.8e008c33.js	1.05kb	+0.00b	4.55s	+378.00ms ⚠️
dist/media-picker-analytics-error-boundary.a20da0c5.js	1003.00b	+0.00b	14.54s	+2.35s ⚠️
dist/media-card-analytics-error-boundary.889a764d.js	999.00b	+0.00b	12.41s	-1.14s 🚀
dist/media-viewer-analytics-error-boundary.880deb8d.js	995.00b	+0.00b	10.43s	-1.70s 🚀

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/card.92b0f4f9.js	54.02kb	+0.00b	627.00ms	+41.00ms ⚠️
dist/Modal.507a0880.js	39.18kb	+0.00b	488.00ms	-42.00ms 🚀
dist/component.e862677c.js	30.82kb	+0.00b	479.00ms	-51.00ms 🚀
dist/ui.bfd5ec70.js	14.21kb	+0.00b	627.00ms	+41.00ms ⚠️
dist/component.dd6e8cc9.js	6.20kb	+0.00b	550.00ms	+43.00ms ⚠️
dist/Modal.19c70720.js	3.14kb	+0.00b	550.00ms	+61.00ms ⚠️
dist/ResourcedEmojiComponent.470ee09d.js	2.15kb	+0.00b	626.00ms	+40.00ms ⚠️
dist/feedback.80c8a178.js	1.86kb	+0.00b	596.00ms	+36.00ms ⚠️
dist/list-number.9bb92c49.js	1.68kb	+0.00b	596.00ms	+47.00ms ⚠️
dist/heading6.f14573d2.js	1.53kb	+0.00b	596.00ms	+36.00ms ⚠️
dist/expand.739e3b88.js	1.38kb	+0.00b	597.00ms	+36.00ms ⚠️
dist/mention.76dc783a.js	1.29kb	+0.00b	596.00ms	+46.00ms ⚠️
dist/list.e0e1a7a9.js	1.18kb	+0.00b	596.00ms	+47.00ms ⚠️
dist/panel-error.210bc7a0.js	1.11kb	+0.00b	596.00ms	+46.00ms ⚠️
dist/panel-note.8e008c33.js	1.05kb	+0.00b	596.00ms	+44.00ms ⚠️
dist/media-card-analytics-error-boundary.ef6306e0.js	999.00b	+0.00b	627.00ms	+41.00ms ⚠️

Three.js ✅

Timings

Description	Time	Difference
Cold	14.09s	+548.00ms
Cached	608.00ms	+28.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/Three.js	580.59kb	+0.00b	99.00ms	+7.00ms ⚠️

Click here to view a detailed benchmark overview.

mischnic · 2020-12-16T15:31:07Z

Apparently, ./ handling has changed between micromatch 3 and 4:

console.log(micromatch3.isMatch("./lib/x", "./lib/*")); // true
console.log(micromatch4.isMatch("./lib/x", "./lib/*")); // false

breaking the resolver. This isn't even mentioned in the changelog of micromatch

mischnic · 2021-01-21T22:37:04Z

I've removed the micromatch change for now.

Seems micromatch 3 and 4 have undocumented behavior differences, So we ignore the version mismatches for now, under the assumption that the specified versions are exhibiting the expected behavior for the packages they are used in. See #5483 (comment) and #5900 (comment)

mischnic requested review from devongovett, wbinnssmith, DeMoorJasper and padmaia December 15, 2020 15:59

mischnic marked this pull request as draft January 20, 2021 12:48

Bump dep on emphasize

3a6157f

mischnic force-pushed the bump-deps branch from fe6f66b to 3a6157f Compare January 21, 2021 22:36

mischnic changed the title ~~Bump two deps with deprecation warnings~~ Bump emphasize Jan 21, 2021

mischnic marked this pull request as ready for review January 21, 2021 22:37

Merge branch 'v2' into bump-deps

c10b1ea

DeMoorJasper approved these changes Jan 22, 2021

View reviewed changes

DeMoorJasper merged commit fa9d4a0 into v2 Jan 22, 2021

DeMoorJasper deleted the bump-deps branch January 22, 2021 09:03

mischnic mentioned this pull request Mar 1, 2021

Make sure the absolute path isn't contained in the cache #5900

Merged

6 tasks

mischnic mentioned this pull request Apr 19, 2021

Add dependency validation script #6155

Open

1 task

mischnic mentioned this pull request Sep 20, 2021

Update Micromatch #6958

Merged

1 task

mischnic mentioned this pull request Nov 3, 2021

micromatch umbrella issue #7242

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump emphasize #5483

Bump emphasize #5483

mischnic commented Dec 15, 2020 •

edited

height bot commented Dec 15, 2020

parcel-benchmark commented Dec 15, 2020 •

edited

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

mischnic commented Dec 16, 2020

mischnic commented Jan 21, 2021

Bump emphasize #5483

Bump emphasize #5483

Conversation

mischnic commented Dec 15, 2020 • edited

height bot commented Dec 15, 2020

parcel-benchmark commented Dec 15, 2020 • edited

Benchmark Results

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

Timings

Cold Bundles

Cached Bundles

mischnic commented Dec 16, 2020

mischnic commented Jan 21, 2021

mischnic commented Dec 15, 2020 •

edited

parcel-benchmark commented Dec 15, 2020 •

edited