Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Micromatch #6958

Merged
merged 3 commits into from Oct 10, 2021
Merged

Update Micromatch #6958

merged 3 commits into from Oct 10, 2021

Conversation

NovaAtWarren
Copy link
Contributor

@NovaAtWarren NovaAtWarren commented Sep 20, 2021

↪️ Pull Request

Updates micromatch to remove security vulnerability, as described in #6942.
EDIT: probably closes #6942

✔️ PR Todo

  • Included links to related issues/PRs

@height
Copy link

height bot commented Sep 20, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic
Copy link
Member

Some tests in https://github.com/parcel-bundler/parcel/blob/v2/packages/utils/node-resolver-core/test/resolver.js fail now, because the two micromatch versions have a slightly different behaviour:

#5483 (comment)

@NovaAtWarren
Copy link
Contributor Author

NovaAtWarren commented Sep 20, 2021

Would you like me to try and update the tests to work with the change?

@mischnic
Copy link
Member

No, the tests are correct and specify the intended behavior of Parcel. You need to adjust how micromatch is called in the implementation or use a different glob matching library if that doesn't work out.

@NovaAtWarren
Copy link
Contributor Author

NovaAtWarren commented Sep 20, 2021

(Hopefully) final question, what dependency am I missing if literally every test fails with the following:

TypeError: (0 , _index.hashString) is not a function
      at generateInstanceId (/home/nova/account/parcel/packages/core/core/src/resolveOptions.js:27:10)
      at resolveOptions (/home/nova/account/parcel/packages/core/core/src/resolveOptions.js:147:17)
      at Parcel._init (/home/nova/account/parcel/packages/core/core/src/Parcel.js:92:42)
      at Parcel.run (/home/nova/account/parcel/packages/core/core/src/Parcel.js:149:7)
      at bundle (/home/nova/account/parcel/packages/core/test-utils/src/utils.js:212:11)
      at Context.<anonymous> (test/vue.js:38:13)

edit: never mind, apparently installing rustup wasn't the final step of installing rustup

@mischnic mischnic added the 📝 WIP Work In Progress label Sep 29, 2021
@thewilkybarkid
Copy link
Contributor

I've just had a go at debugging this, and I think it's hitting micromatch/picomatch#77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update micromatch in @parcel/utils to avoid set-value package < 4.0.1
4 participants