Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type/Test HMRRuntime #5926

Merged
merged 4 commits into from
Mar 5, 2021
Merged

Type/Test HMRRuntime #5926

merged 4 commits into from
Mar 5, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Feb 27, 2021

  1. Should fix the error mentioned in Parcel 2 transformers "asset.addIncludedFile()" #5677 (reply in thread). This was introduced in the lazy-bundling PR, asset was a string in some cases here:
    if (!asset.depsByBundle[bundle.HMR_BUNDLE_ID]) {
  2. Flow-type the HMR runtime (which would have caught 1.)
  3. Add some minimal tests for the HMR client runtime.

Related to: #2497

Closes #5962

@height
Copy link

height bot commented Feb 27, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Feb 27, 2021

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit dccbe72 into v2 Mar 5, 2021
@mischnic mischnic deleted the flowify-hmr-runtime branch March 5, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hmrAcceptCheck: Cannot read property … of undefined
3 participants