Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds '@parcel/diagnostic' to dependencies #6563

Merged
merged 1 commit into from Jul 7, 2021
Merged

Adds '@parcel/diagnostic' to dependencies #6563

merged 1 commit into from Jul 7, 2021

Conversation

tdstein
Copy link
Contributor

@tdstein tdstein commented Jul 7, 2021

↪️ Pull Request

An import to '@parcel/diagnostic' was added to TypeScriptValidator, but wasn't added to the dependency list.

The resulted in the falling build error when using nightly.

🚨 Build failed.

@parcel/validator-typescript: Could not resolve module "@parcel/diagnostic" ... /node_modules/@parcel/validator-typescript/lib/TypeScriptValidator.js"

@height
Copy link

height bot commented Jul 7, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic mischnic merged commit 3ed0b72 into parcel-bundler:v2 Jul 7, 2021
lettertwo added a commit that referenced this pull request Jul 13, 2021
* v2: (34 commits)
  Wrap assets recursively when any incoming dependency is wrapped (#6572)
  Improvements for library targets (#6570)
  Diagnostic for undeclared external dependencies in library builds (#6564)
  More bugs (#6567)
  Don't require `url:` for image transformer (#6565)
  Remove 'Name already registered with serializer' error (#6566)
  Fix live bindings and `this` of external CommonJS modules (#6548)
  JS runtime improvements (#6531)
  Make sure the absolute path isn't contained in the cache (#5900)
  Adds '@parcel/diagnostic' to dependencies (#6563)
  Disable workers with string literals and improve diagnostics (#6536)
  Bug fixes (#6541)
  Don't attempt to resolve URLs starting with '#' (#6504)
  Correctly set worker's output format if not support by environment (#6534)
  Babel: Recognize peerDependencies in isJSX (#6497)
  fix setHeaders ordering on dev server (#6500)
  Graph: Remove Node interface (#6530)
  Fix TS build script for old Node versions (#6526)
  Improve library targets (#6517)
  Fix TypeScript and other sourcemaps by always creating an initial sourcemap (#6472)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants