Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More bugs #6567

Merged
merged 5 commits into from Jul 8, 2021
Merged

More bugs #6567

merged 5 commits into from Jul 8, 2021

Conversation

devongovett
Copy link
Member

  • Reloads the page if multiple assets changed and not all of them were accepted by HMR. This happens e.g. when changing an HTML file with Tailwind. The CSS gets accepted, but the HTML does not, and the page doesn't get reloaded currently. Fixes Parcel 2 doesnt send file change over HMR #6393.
  • Fixes React Fast Refresh runtime not being applied with the new automatic JSX runtime, which doesn't require a dependency on "react" to be in the file. Now we also look for "react/jsx-runtime".
  • If the resolver failed but then the error was fixed (e.g. file didn't exist and it was created), we didn't trigger a rebuild and you had to restart Parcel. This was because the invalidations were never added to the graph. Now we do this before throwing the error.
  • new URL('something', import.meta.url) was getting transformed into a require of a runtime and returning a string instead of an actual URL object. Now it's transformed into new URL(require('something')) instead.

@height
Copy link

height bot commented Jul 8, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 10.84s -54.00ms
Cached 540.00ms -18.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/logo.1e014c76.png 274.00b +0.00b 299.00ms +40.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.1e014c76.png 274.00b +0.00b 264.00ms -32.00ms 🚀

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 7.91s +240.00ms
Cached 469.00ms -28.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

return null;
return {
assetGroup: null,
invalidateOnFileCreate,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

@devongovett devongovett merged commit db75d9c into v2 Jul 8, 2021
@devongovett devongovett deleted the more-bugs branch July 8, 2021 19:43
lettertwo added a commit that referenced this pull request Jul 13, 2021
* v2: (34 commits)
  Wrap assets recursively when any incoming dependency is wrapped (#6572)
  Improvements for library targets (#6570)
  Diagnostic for undeclared external dependencies in library builds (#6564)
  More bugs (#6567)
  Don't require `url:` for image transformer (#6565)
  Remove 'Name already registered with serializer' error (#6566)
  Fix live bindings and `this` of external CommonJS modules (#6548)
  JS runtime improvements (#6531)
  Make sure the absolute path isn't contained in the cache (#5900)
  Adds '@parcel/diagnostic' to dependencies (#6563)
  Disable workers with string literals and improve diagnostics (#6536)
  Bug fixes (#6541)
  Don't attempt to resolve URLs starting with '#' (#6504)
  Correctly set worker's output format if not support by environment (#6534)
  Babel: Recognize peerDependencies in isJSX (#6497)
  fix setHeaders ordering on dev server (#6500)
  Graph: Remove Node interface (#6530)
  Fix TS build script for old Node versions (#6526)
  Improve library targets (#6517)
  Fix TypeScript and other sourcemaps by always creating an initial sourcemap (#6472)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcel 2 doesnt send file change over HMR
3 participants