Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to prettier 2 #7209

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Update to prettier 2 #7209

merged 2 commits into from
Nov 1, 2021

Conversation

mischnic
Copy link
Member

Mostly because of the problem I ran into in #7208

But I find most of these changes here more readable than before.

@height
Copy link

height bot commented Oct 28, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 28, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.71s +28.00ms
Cached 260.00ms -13.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 560.00ms +39.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 561.00ms +39.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 561.00ms +40.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 8.84s -7.00ms
Cached 413.00ms -13.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 57.58s +228.00ms
Cached 1.53s +23.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.d173b989.js 693.74kb +0.00b 32.33s -11.38s 🚀
dist/editorView.88c79e9e.js 594.83kb +0.00b 32.33s -10.96s 🚀
dist/popup.64bc9a82.js 209.67kb +0.00b 32.33s -10.96s 🚀
dist/index.17612478.js 145.62kb +0.00b 32.33s -11.36s 🚀
dist/Toolbar.e3ba4416.js 107.23kb +0.00b 32.33s -10.96s 🚀
dist/card.8ef34b4f.js 62.67kb +0.00b 32.33s -11.36s 🚀
dist/Modal.cd71eaf3.js 45.33kb +0.00b 32.33s -10.96s 🚀
dist/js.660b75db.js 17.25kb +0.00b 32.33s -10.96s 🚀
dist/ui.5d3f7adc.js 14.94kb +0.00b 32.33s -10.96s 🚀
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 32.33s -10.96s 🚀
dist/dropzone.e0209bf8.js 12.15kb +0.00b 32.33s -10.96s 🚀
dist/card.26823fa1.js 5.77kb +0.00b 32.33s -11.36s 🚀
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 32.33s -10.96s 🚀
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 32.33s -10.94s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 32.33s -10.96s 🚀
dist/Modal.ecafad9e.js 3.15kb +0.00b 32.33s -11.37s 🚀
dist/clipboard.df70240c.js 2.93kb +0.00b 32.33s -10.96s 🚀
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 32.33s -10.96s 🚀
dist/browser.4e039ed7.js 1.69kb +0.00b 32.33s -10.96s 🚀
dist/heading4.094fd60f.js 1.27kb +0.00b 17.61s -9.23s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 32.33s -10.96s 🚀
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 32.33s -10.96s 🚀
dist/media-card-analytics-error-boundary.30f51dac.js 962.00b +0.00b 32.33s -11.36s 🚀
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 32.33s -10.96s 🚀

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.11s +9.00ms
Cached 352.00ms +17.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit e0440dc into v2 Nov 1, 2021
@devongovett devongovett deleted the prettier-2 branch November 1, 2021 18:45
lettertwo added a commit that referenced this pull request Nov 15, 2021
* v2: (68 commits)
  Fix RangeError in `not export` error with other file type (#7295)
  Apply sourcemap in @parcel/transformer-typescript-tsc (#7287)
  Fix side effects glob matching (#7288)
  Fix changelog headings
  v2.0.1
  Changelog for v2.0.1
  Resolve GLSL relative to the importer, not the asset (#7263)
  fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248)
  Fixed missing "Parcel" export member in Module "@parcel/core" (#7250)
  Add script to sync engines with core version (#7207)
  Bump swc (#7216)
  Make Webpack loader detection regex dramatically faster (#7226)
  swc optimizer (#7212)
  Update esbuild in optimizer (#7233)
  Properly visit member expressions (#7228)
  Update to prettier 2 (#7209)
  Fix serve mode with target override and target source fields (#7187)
  Update package.json to include the repository (#7184)
  fix #6730: add transformer-raw as dependency of config-webextension (#7193)
  Log warning instead of crash if image optimizer fails (#7119)
  ...
lettertwo added a commit that referenced this pull request Nov 15, 2021
* v2: (68 commits)
  Fix RangeError in `not export` error with other file type (#7295)
  Apply sourcemap in @parcel/transformer-typescript-tsc (#7287)
  Fix side effects glob matching (#7288)
  Fix changelog headings
  v2.0.1
  Changelog for v2.0.1
  Resolve GLSL relative to the importer, not the asset (#7263)
  fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248)
  Fixed missing "Parcel" export member in Module "@parcel/core" (#7250)
  Add script to sync engines with core version (#7207)
  Bump swc (#7216)
  Make Webpack loader detection regex dramatically faster (#7226)
  swc optimizer (#7212)
  Update esbuild in optimizer (#7233)
  Properly visit member expressions (#7228)
  Update to prettier 2 (#7209)
  Fix serve mode with target override and target source fields (#7187)
  Update package.json to include the repository (#7184)
  fix #6730: add transformer-raw as dependency of config-webextension (#7193)
  Log warning instead of crash if image optimizer fails (#7119)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants