Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swc to fix ESM helpers #8213

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Bump swc to fix ESM helpers #8213

merged 5 commits into from
Jun 16, 2022

Conversation

devongovett
Copy link
Member

Fixes an issue where SWC's helpers didn't work with Node ESM. SWC now generates .mjs imports, and rewrites them to the CommonJS version when transforming. Now we do the same. Based on swc-project/swc#4962

@parcel-benchmark
Copy link

parcel-benchmark commented Jun 15, 2022

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.02s +175.00ms ⚠️
Cached 386.00ms -19.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 102.00ms +8.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 103.00ms +8.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 103.00ms +9.00ms ⚠️
dist/legacy/index.2c76ad23.js 1.66kb +0.00b 611.00ms +40.00ms ⚠️
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 610.00ms +39.00ms ⚠️
dist/modern/index.6be20f01.js 1.13kb +0.00b 610.00ms +40.00ms ⚠️
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 340.00ms +31.00ms ⚠️
dist/modern/index.31cedca9.css 94.00b +0.00b 340.00ms +31.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 102.00ms +10.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 104.00ms +10.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 104.00ms +11.00ms ⚠️
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 326.00ms +24.00ms ⚠️
dist/modern/index.31cedca9.css 94.00b +0.00b 326.00ms +25.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 10.79s -226.00ms
Cached 522.00ms +25.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.96m +657.00ms
Cached 2.98s +197.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/index.62b99daf.js 3.33mb +0.00b 41.55s +3.38s ⚠️
dist/index.496c02ee.js 1.27mb +0.00b 1.60m +8.38s ⚠️
dist/pdfRenderer.f837d787.js 1.11mb +0.00b 1.60m +8.37s ⚠️
dist/editorView.34322e2f.js 606.88kb +0.00b 1.60m +8.37s ⚠️
dist/refractor.aa9d6b22.js 599.28kb +0.00b 1.60m +8.37s ⚠️
dist/media-viewer.389e4abc.js 440.33kb +0.00b 1.60m +8.37s ⚠️
dist/card.6e510e6f.js 366.74kb +0.00b 1.60m +8.36s ⚠️
dist/popup.2cc0d9cd.js 314.51kb +0.00b 52.32s +4.63s ⚠️
dist/ConfigPanelFieldsLoader.06470302.js 287.98kb +0.00b 46.19s +4.02s ⚠️
dist/EmojiPickerComponent.9d8e543c.js 187.29kb +0.00b 41.56s +3.38s ⚠️
dist/mobile-upload.b893855e.js 68.22kb +0.00b 41.55s +3.38s ⚠️
dist/esm.d33c658d.js 65.60kb +0.00b 52.32s +4.63s ⚠️
dist/esm.c7dc1640.js 61.96kb +0.00b 1.60m +8.37s ⚠️
dist/esm.8bf6e75d.js 61.96kb +0.00b 1.60m +8.36s ⚠️
dist/archive.3274e3f0.js 61.48kb +0.00b 1.60m +8.37s ⚠️
dist/ElementBrowser.3a733953.js 57.29kb +0.00b 47.71s +4.16s ⚠️
dist/DatePicker.c3dfe370.js 46.98kb +0.00b 46.19s +4.02s ⚠️
dist/component.ea2c474a.js 38.70kb +0.00b 47.71s +4.16s ⚠️
dist/Modal.bd1ae2b2.js 31.41kb +0.00b 1.60m +8.37s ⚠️
dist/DatePicker.63d5864f.js 26.86kb +0.00b 46.19s +4.02s ⚠️
dist/component-lazy.01028ffb.js 20.54kb +0.00b 47.71s +4.16s ⚠️
dist/js.59c58b0d.js 17.25kb +0.00b 1.60m +8.37s ⚠️
dist/ConfigPanelFieldsLoader.dd206ecf.js 16.35kb +0.00b 47.71s +4.16s ⚠️
dist/smartMediaEditor.cc30e433.js 15.27kb +0.00b 1.60m +8.37s ⚠️
dist/ui.8102caad.js 14.07kb +0.00b 47.71s +4.16s ⚠️
dist/dropzone.fedc3def.js 13.82kb +0.00b 52.32s +4.63s ⚠️
dist/pdfRenderer.d23553db.js 12.17kb +0.00b 52.35s +4.66s ⚠️
dist/Toolbar.8b0fdf7f.js 9.24kb +0.00b 1.60m +8.37s ⚠️
dist/mobile-upload.bf388fdf.js 8.10kb +0.00b 41.55s +3.38s ⚠️
dist/mobile-upload.dd98bc2b.js 8.10kb +0.00b 1.60m +8.37s ⚠️
dist/mobile-upload.f52711ff.js 8.10kb +0.00b 1.60m +8.37s ⚠️
dist/mobile-upload.6f4c69b6.js 8.10kb +0.00b 1.60m +8.37s ⚠️
dist/dropzone.f93d7dd9.js 7.36kb +0.00b 52.32s +4.63s ⚠️
dist/component-lazy.a40a67db.js 6.85kb +0.00b 47.71s +4.16s ⚠️
dist/EmojiPickerComponent.16132f88.js 5.54kb +0.00b 41.55s +3.38s ⚠️
dist/media-viewer.7ba2bb8e.js 4.36kb +0.00b 52.35s +4.66s ⚠️
dist/index.b16227d6.css 4.08kb +0.00b 1.60m +8.39s ⚠️
dist/Modal.0be8065c.js 3.78kb +0.00b 1.60m +8.37s ⚠️
dist/clipboard.eb5719cd.js 3.60kb +0.00b 52.35s +4.66s ⚠️
dist/png-chunks-extract.f2395929.js 3.47kb +0.00b 1.60m +8.37s ⚠️
dist/ru.fdb600e7.js 2.94kb +0.00b 47.71s +4.16s ⚠️
dist/uk.aeae0dd4.js 2.91kb +0.00b 47.71s +4.16s ⚠️
dist/browser.72e17e1d.js 2.86kb +0.00b 52.35s +4.66s ⚠️
dist/codeViewerRenderer.ec9409ba.js 2.79kb +0.00b 1.60m +8.37s ⚠️
dist/th.bcd8fad5.js 2.75kb +0.00b 47.71s +4.16s ⚠️
dist/card.8e8152fc.js 2.71kb +0.00b 52.35s +4.67s ⚠️
dist/ResourcedEmojiComponent.bef36b85.js 2.68kb +0.00b 41.55s +3.38s ⚠️
dist/media-viewer-analytics-error-boundary.8669c765.js 2.39kb +0.00b 52.35s +4.66s ⚠️
dist/pl.4643976c.js 2.37kb +0.00b 46.19s +4.01s ⚠️
dist/cs.08737142.js 2.28kb +0.00b 46.19s +4.02s ⚠️
dist/de.c2e79abd.js 2.26kb +0.00b 46.19s +4.02s ⚠️
dist/es.983af340.js 2.24kb +0.00b 46.19s +4.01s ⚠️
dist/ja.b56014f3.js 2.24kb +0.00b 46.19s +4.01s ⚠️
dist/fr.aaa4d0bf.js 2.20kb +0.00b 46.19s +4.01s ⚠️
dist/pt_BR.6c08dcf7.js 2.17kb +0.00b 46.19s +4.01s ⚠️
dist/hu.3d2e30a0.js 2.17kb +0.00b 46.19s +4.01s ⚠️
dist/component-lazy.feb4b6cd.js 2.16kb +0.00b 47.72s +4.16s ⚠️
dist/tr.3968c433.js 2.15kb +0.00b 47.71s +4.16s ⚠️
dist/vi.bf757a1c.js 2.15kb +0.00b 47.71s +4.16s ⚠️
dist/fi.080f52aa.js 2.13kb +0.00b 46.19s +4.01s ⚠️
dist/ko.51863560.js 2.13kb +0.00b 46.19s +4.01s ⚠️
dist/it.7bb93510.js 2.12kb +0.00b 46.19s +4.01s ⚠️
dist/nb.67163f41.js 2.10kb +0.00b 46.19s +4.01s ⚠️
dist/date.728667d8.js 2.10kb +0.00b 41.55s +3.38s ⚠️
dist/sv.51378563.js 2.09kb +0.00b 47.71s +4.16s ⚠️
dist/nl.336a2549.js 2.09kb +0.00b 46.19s +4.01s ⚠️
dist/da.f39b0c8c.js 2.07kb +0.00b 46.19s +4.02s ⚠️
dist/images.0fe0f35c.js 2.05kb +0.00b 41.55s +3.38s ⚠️
dist/zh_TW.6ca95d33.js 2.00kb +0.00b 47.71s +4.16s ⚠️
dist/zh.9b716de5.js 1.99kb +0.00b 47.71s +4.16s ⚠️
dist/feedback.2ade51a8.js 1.92kb +0.00b 46.19s +4.02s ⚠️
dist/status.2160efcd.js 1.82kb +0.00b 41.56s +3.39s ⚠️
dist/workerHasher.0904bc5b.js 1.72kb +0.00b 41.55s +3.38s ⚠️
dist/workerHasher.6290622a.js 1.72kb +0.00b 52.32s +4.63s ⚠️
dist/workerHasher.23d0f86c.js 1.72kb +0.00b 52.32s +4.63s ⚠️
dist/workerHasher.e50d242f.js 1.72kb +0.00b 1.60m +8.37s ⚠️
dist/workerHasher.6ae6406c.js 1.72kb +0.00b 1.60m +8.36s ⚠️
dist/workerHasher.1e502a56.js 1.72kb +0.00b 1.60m +8.37s ⚠️
dist/code.414e2c00.js 1.72kb +0.00b 41.55s +3.38s ⚠️
dist/component.e636e8c4.js 1.63kb +0.00b 47.71s +4.16s ⚠️
dist/list-number.2be0cd6c.js 1.62kb +0.00b 41.56s +3.38s ⚠️
dist/heading6.e0c2f3cf.js 1.52kb +0.00b 46.19s +4.02s ⚠️
dist/heading3.5b4663e8.js 1.51kb +0.00b 46.19s +4.02s ⚠️
dist/16.d28358f5.js 1.48kb +0.00b 52.32s +4.63s ⚠️
dist/link.1e33efbb.js 1.43kb +0.00b 41.56s +3.38s ⚠️
dist/media-picker-analytics-error-boundary.c847f974.js 1.42kb +0.00b 52.35s +4.67s ⚠️
dist/media-viewer-analytics-error-boundary.7df0b867.js 1.42kb +0.00b 1.60m +8.37s ⚠️
dist/media-card-analytics-error-boundary.d3d23440.js 1.42kb +0.00b 1.60m +8.37s ⚠️
dist/16.86f26d3d.js 1.41kb +0.00b 47.72s +4.16s ⚠️
dist/emoji.5404dc09.js 1.40kb +0.00b 41.55s +3.38s ⚠️
dist/heading5.df611011.js 1.39kb +0.00b 46.19s +4.02s ⚠️
dist/expand.655beb16.js 1.33kb +0.00b 46.19s +4.02s ⚠️
dist/heading2.54f14b16.js 1.33kb +0.00b 46.19s +4.02s ⚠️
dist/heading4.3ae44c0a.js 1.28kb +0.00b 46.19s +4.02s ⚠️
dist/mention.85e501f2.js 1.24kb +0.00b 41.56s +3.38s ⚠️
dist/layout.dde5aa7a.js 1.20kb +0.00b 41.55s +3.38s ⚠️
dist/divider.3af42f3a.js 1.20kb +0.00b 41.55s +3.38s ⚠️
dist/action.633b1d3a.js 1.17kb +0.00b 41.55s +3.38s ⚠️
dist/heading1.216107b4.js 1.17kb +0.00b 41.56s +3.38s ⚠️
dist/list.1bd3e768.js 1.14kb +0.00b 41.56s +3.38s ⚠️
dist/quote.707178c1.js 1.14kb +0.00b 41.56s +3.39s ⚠️
dist/16.7c57bd8b.js 1.13kb +0.00b 52.31s +4.63s ⚠️
dist/ConfigPanelFieldsLoader.fee2d8bd.js 1.12kb +0.00b 47.71s +4.16s ⚠️
dist/decision.5c187f01.js 1.12kb +0.00b 41.55s +3.38s ⚠️
dist/panel-warning.817f153e.js 1.10kb +0.00b 41.56s +3.39s ⚠️
dist/16.878668fc.js 1.08kb +0.00b 47.72s +4.16s ⚠️
dist/16.1969624f.js 1.08kb +0.00b 52.31s +4.62s ⚠️
dist/table.71e953fa.js 1.08kb +0.00b 41.56s +3.38s ⚠️
dist/16.9db4c5fc.js 1.06kb +0.00b 47.71s +4.16s ⚠️
dist/16.6bd01cc7.js 1.06kb +0.00b 52.32s +4.63s ⚠️
dist/16.a4b6862e.js 1.02kb +0.00b 52.32s +4.63s ⚠️
dist/panel.63b53aef.js 1.02kb +0.00b 41.56s +3.39s ⚠️
dist/panel-error.3c204bc9.js 1019.00b +0.00b 41.56s +3.38s ⚠️
dist/16.f5881244.js 991.00b +0.00b 52.31s +4.63s ⚠️
dist/ConfigPanelFieldsLoader.3cc97f45.js 975.00b +0.00b 47.71s +4.15s ⚠️
dist/16.0e28197b.js 963.00b +0.00b 52.31s +4.63s ⚠️
dist/panel-success.bfed2890.js 960.00b +0.00b 41.56s +3.38s ⚠️
dist/16.bcad6da7.js 956.00b +0.00b 47.71s +4.16s ⚠️
dist/panel-note.badaa0b2.js 950.00b +0.00b 41.56s +3.38s ⚠️
dist/16.006f2efd.js 950.00b +0.00b 52.32s +4.63s ⚠️
dist/media-viewer.e4a4cc34.js 935.00b +0.00b 52.35s +4.66s ⚠️
dist/16.b50bd25c.js 911.00b +0.00b 52.32s +4.63s ⚠️
dist/16.050fcc44.js 905.00b +0.00b 47.72s +4.16s ⚠️
dist/16.069344b7.js 905.00b +0.00b 52.31s +4.62s ⚠️
dist/16.c2636906.js 904.00b +0.00b 52.31s +4.63s ⚠️
dist/16.61242a1f.js 903.00b +0.00b 47.72s +4.16s ⚠️
dist/16.37ce783c.js 902.00b +0.00b 47.71s +4.16s ⚠️
dist/16.f353315d.js 875.00b +0.00b 52.32s +4.63s ⚠️
dist/16.d9e53846.js 854.00b +0.00b 47.71s +4.16s ⚠️
dist/16.75acb770.js 826.00b +0.00b 52.32s +4.63s ⚠️
dist/sk.dd4e83c8.js 791.00b +0.00b 47.71s +4.16s ⚠️
dist/pt_PT.1eda577d.js 786.00b +0.00b 46.19s +4.01s ⚠️
dist/et.03b90e09.js 778.00b +0.00b 46.19s +4.01s ⚠️
dist/simpleHasher.2e0de700.js 742.00b +0.00b 41.55s +3.38s ⚠️
dist/simpleHasher.76c4e98e.js 742.00b +0.00b 52.32s +4.63s ⚠️
dist/simpleHasher.cc19c690.js 742.00b +0.00b 52.32s +4.63s ⚠️
dist/simpleHasher.46d6f2e5.js 742.00b +0.00b 1.60m +8.37s ⚠️
dist/simpleHasher.28ade3b5.js 742.00b +0.00b 1.60m +8.37s ⚠️
dist/simpleHasher.82f6b150.js 742.00b +0.00b 1.60m +8.37s ⚠️
dist/is.0d0b2897.js 638.00b +0.00b 46.19s +4.01s ⚠️
dist/ro.82d888a1.js 633.00b +0.00b 47.71s +4.16s ⚠️
dist/en_GB.a4eaa606.js 623.00b +0.00b 46.19s +4.01s ⚠️
dist/en.dced70ab.js 620.00b +0.00b 46.19s +4.02s ⚠️
dist/ConfigPanelFieldsLoader.e3b1a5db.js 490.00b +0.00b 47.71s +4.16s ⚠️
dist/index.html 240.00b +0.00b 1.60m +8.39s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 8.14s -98.00ms
Cached 323.00ms -6.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 6b372ec into v2 Jun 16, 2022
@devongovett devongovett deleted the bump-swc branch June 16, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants