-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stream#pipeline instead of stream.pipe #8235
Conversation
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
Could you describe in short why this is the case?
|
The only explanation I have is that |
Hmm, maybe
|
Fixes
No such file: "../.parcel-cache/283921823"
A regression from #8194
Apparently this call would still return even though the stream wasn't fully written yet (and therefore the file wasn't renamed):
Using
stream.pipeline
works (which also has official promise capabilities).Tested in a project that would previously fail deterministically with that error on every build. Now I don't see the error anymore