HTML bundle serving bug. #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
=========================================
- Coverage 89.46% 88.6% -0.86%
=========================================
Files 68 68
Lines 3341 3440 +99
=========================================
+ Hits 2989 3048 +59
- Misses 352 392 +40
Continue to review full report at Codecov.
|
DeMoorJasper
added a commit
that referenced
this pull request
Mar 10, 2018
src/Server.js
Outdated
| @@ -49,6 +50,11 @@ function middleware(bundler) { | |||
| } else { | |||
| // Otherwise, serve the file from the dist folder | |||
| req.url = req.url.slice(bundler.options.publicURL.length); | |||
| // If we're serving an html bundle, and the requested path has not file | |||
| // extension, serve the index.html. Otherwise go to the file server. | |||
| if (bundler.mainAsset.type === 'html' && path.extname(req.url) == "") { | |||
There was a problem hiding this comment.
This would break any file that doesn't have an extension?
There was a problem hiding this comment.
Currently only HTML is served, so it wouldn't change the behavior. But it's true that it will not serve files without extensions - I'd argue that is desired behavior for single page apps.
|
@ry @DeMoorJasper Is this a duplicate of #838? I noticed that #838 closes this PR 🤔 🤷♂️ |
When serving HTML bundle with publicUrl="/", allow the server to send static assets other than html.
|
Thanks! |
devongovett
added a commit
that referenced
this pull request
Mar 22, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
added a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
added a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serving HTML bundle with publicUrl="/", allow the server to send static assets other than html.
Fixes #782