Adds ./tools/dev_website for fast incremental builds #346
Conversation
|
× C:\Users\BertBelder\d\propel3\website\main.scss:undefined:undefined: Missing binding C:\Users\BertBelder\d\propel3\deps\node_modules\node-sass\vendor\win32-x64-57\binding.node Found bindings for the following environments:
|
|
Nice. Although I am a bit concerned by the code duplication between build_website and dev_website. |
|
Patch sent upstream: parcel-bundler/parcel#974 |
ry
force-pushed
the
dev_website
branch
3 times, most recently
from
ccc841a
to
b57e1b8
Compare
tools/build.js
Outdated
| @@ -6,6 +6,7 @@ if (process.argv.indexOf("clean") >= 0) { | |||
| } | |||
|
|
|||
| (async() => { | |||
| run.sh("npm rebuild"); | |||
There was a problem hiding this comment.
This fails on windows. Cannot spawn .cmd files. Use execSync instead.
There was a problem hiding this comment.
Actually can we not have this here at all? npm rebuild is way too slow for me to want to do that all the time.
tools/build.js
Outdated
| @@ -6,6 +6,7 @@ if (process.argv.indexOf("clean") >= 0) { | |||
| } | |||
|
|
|||
| (async() => { | |||
| run.sh("npm rebuild"); | |||
There was a problem hiding this comment.
Actually can we not have this here at all? npm rebuild is way too slow for me to want to do that all the time.
|
@piscisaureus Removed node-sass and used a symlink to sass. Removed the npm rebuild too. PTAL. |
For fast incremental website builds
The deps commit includes some hacks on parcel to fix a bug - I will send upstream soon
propelml/propel_deps@4103536#diff-5e9e9af54dc82093dc2e5334dfff25c3