Add simple reporting to request tracker #9811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamadapc
reviewed
Jun 20, 2024
MonicaOlejniczak
force-pushed
the
molejniczak/simple-reporting
branch
from
b92445d
to
df9379a
Compare
MonicaOlejniczak
force-pushed
the
molejniczak/simple-reporting
branch
from
df9379a
to
18414ae
Compare
yamadapc
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
These changes fill out the
reportfn on the request context using a naive implementation to flesh out the empty placeholder. Later on we should decide if we need the equivalent of theReporterRunnerfrom JavaScript, and determine if all / certain events should be run sync / async.🚨 Test instructions
yarn build-native && cargo test