Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'postBodyFilter' block signature update. #4

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Conversation

parfeon
Copy link
Owner

@parfeon parfeon commented Jul 31, 2018

Block signature and usage has been updated, because when VCR plays stubbed data, HTTP post body at the moment of block call already sent to HTTP post body stream and nullified.
Update allows to get content which has been sent to body stream and work with it.

…ual NSURLRequest body (for stubbed requests it is `nil` since body's content is part of stream)
@parfeon parfeon added the enhancement New feature or request label Jul 31, 2018
@parfeon parfeon self-assigned this Jul 31, 2018
@parfeon parfeon changed the title postBodyFilterblock signature update. 'postBodyFilter' block signature update. Jul 31, 2018
@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #4 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   97.81%   97.82%   +<.01%     
==========================================
  Files          40       40              
  Lines        3475     3488      +13     
==========================================
+ Hits         3399     3412      +13     
  Misses         76       76
Impacted Files Coverage Δ
.../Integration/YHVCassettePlaybackIntegerationTest.m 100% <100%> (ø) ⬆️
YAHTTPVCR/Core/YHVVCR.m 100% <100%> (ø) ⬆️
Tests/Helpers/YHVIntegrationTestCase.m 93.68% <100%> (+0.06%) ⬆️
Tests/Unit/Core/YHVVCRTest.m 97.45% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124260e...00dba87. Read the comment docs.

@parfeon parfeon merged commit 104cdc2 into master Jul 31, 2018
@parfeon parfeon deleted the post-filter-pass-body branch July 31, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants