Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rococo initialization in the registry #297

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Sep 26, 2023

rel: #293

This ensures that the registry can initialize with rococo as the relay chain.

Important note:

In order to use rococo's asset hub with the AssetTransferApi one will need to hardcode the specName into the initialization like the following:

new AssetTransferApi(api, `asset-hub-rococo`, xcmVersion);

The reason being, kusama's asset hub and and rococo's asset-hub both share the same specName currently and will cause conflicts. We currently do an overewrite in the registry that the api uses and set the specName for rococo's asset hub to be asset-hub-rococo. This should be resolved at a higher level in the below PR for asset-hub's spec.

rel: paritytech/polkadot-sdk#1215

@TarikGul
Copy link
Member Author

TarikGul commented Sep 26, 2023

Im running into one issue that I can see will be a potential bug.

The specName for rococos asset-hub is also statemine... Which would cause a conflict in lookup.

@TarikGul TarikGul merged commit efbe7c3 into main Sep 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants