Added commenting of errors #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/merge help |
Auto-Merge-BotAvailable commands
For more information see the documentation |
|
/merge |
Auto-Merge-BotUser @rzadp is not the author of the PR and does not publicly belong to the org Only author or public org members can trigger the bot. |
rzadp
approved these changes
Sep 28, 2023
|
/merge |
This way it won't be ignored in silent mode
|
/merge |
Bullrich
force-pushed
the
comment-errors
branch
from
e525bfe
to
7093fac
Compare
|
Enabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a call to the comment function inside the
catchblock.Just to be sure, we are logging the error first in the case that the comment fails.
The intention is that, if it fails for a configuration reason, the bot will be able to report that. (If it fails because of the commenting feature then it won't be able to report it).
A good example is that it is set for
MERGEbut it is not allowed in the repository (orauto-mergeis disabled).This resolves #2