Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

feat: add call method to SignedExtrinsicRune #952

Merged
merged 9 commits into from May 5, 2023
Merged

feat: add call method to SignedExtrinsicRune #952

merged 9 commits into from May 5, 2023

Conversation

ryanleecode
Copy link
Contributor

@ryanleecode ryanleecode commented May 1, 2023 •
edited by harrysolovay

Closes #950

@ryanleecode ryanleecode mentioned this pull request May 1, 2023
Closed
@ryanleecode ryanleecode marked this pull request as ready for review May 1, 2023 22:16
@ryanleecode ryanleecode force-pushed the feat/extrinsic-signed-extrinsic-rune branch from 11541a2 to 261c0ef Compare May 4, 2023 16:21
@ryanleecode ryanleecode force-pushed the feat/extrinsic-signed-extrinsic-rune branch from 261c0ef to 2877080 Compare May 4, 2023 20:35
harrysolovay
harrysolovay previously approved these changes May 5, 2023
View reviewed changes
kratico
kratico previously approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@kratico kratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@harrysolovay harrysolovay dismissed stale reviews from kratico and themself via 5fc0645 May 5, 2023 13:35
@harrysolovay harrysolovay changed the title feat: add extrinsic method to signed extrinsic rune feat: add unsigned method to SignedExtrinsicRune May 5, 2023
@ryanleecode ryanleecode changed the title feat: add unsigned method to SignedExtrinsicRune feat: add call method to SignedExtrinsicRune May 5, 2023
ryanleecode
ryanleecode commented May 5, 2023
View reviewed changes
Copy link
Contributor Author

@ryanleecode ryanleecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harrysolovay harrysolovay added this pull request to the merge queue May 5, 2023
Merged via the queue into main with commit 72625e1 May 5, 2023
16 checks passed
@harrysolovay harrysolovay deleted the feat/extrinsic-signed-extrinsic-rune branch May 5, 2023 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harrysolovay harrysolovay harrysolovay approved these changes

@tjjfvi tjjfvi tjjfvi approved these changes

@kratico kratico kratico left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

option to convert signed extrinsic rune back to extrinsic rune
4 participants
@ryanleecode @kratico @harrysolovay @tjjfvi